| Message ID | 20240712003307.64005-2-jamrial@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/2] avcodec/bsf/showinfo: print packet side data and flags | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_fate_x86 | success | Make fate finished |
| andriy/make_x86 | warning | New warnings during build |
Quoting James Almer (2024-07-12 02:33:07) > Signed-off-by: James Almer <jamrial@gmail.com> > --- > libavcodec/bsf/showinfo.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c > index 0899263545..57da3fc73c 100644 > --- a/libavcodec/bsf/showinfo.c > +++ b/libavcodec/bsf/showinfo.c > @@ -23,6 +23,7 @@ > #include "bsf.h" > #include "bsf_internal.h" > > +#include "libavutil/adler32.h" > #include "libavutil/internal.h" > #include "libavutil/log.h" > #include "libavutil/timestamp.h" > @@ -34,22 +35,25 @@ typedef struct ShowinfoContext { > static int showinfo_filter(AVBSFContext *ctx, AVPacket *pkt) > { > ShowinfoContext *priv = ctx->priv_data; > + uint32_t crc; > int ret; > > ret = ff_bsf_get_packet_ref(ctx, pkt); > if (ret < 0) > return ret; > > + crc = av_adler32_update(0, pkt->data, pkt->size); > av_log(ctx, AV_LOG_INFO, > "n:%7"PRIu64" " > "size:%7d " > "pts:%s pt:%s " > "dts:%s dt:%s " > "ds:%"PRId64" d:%s " > + "0x%08"PRIx32, could you prefix it with checksum: or something, so it's clear what it means?
Quoting James Almer (2024-07-13 16:05:35) > Signed-off-by: James Almer <jamrial@gmail.com> > --- > libavcodec/bsf/showinfo.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) LGTM
diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c index 0899263545..57da3fc73c 100644 --- a/libavcodec/bsf/showinfo.c +++ b/libavcodec/bsf/showinfo.c @@ -23,6 +23,7 @@ #include "bsf.h" #include "bsf_internal.h" +#include "libavutil/adler32.h" #include "libavutil/internal.h" #include "libavutil/log.h" #include "libavutil/timestamp.h" @@ -34,22 +35,25 @@ typedef struct ShowinfoContext { static int showinfo_filter(AVBSFContext *ctx, AVPacket *pkt) { ShowinfoContext *priv = ctx->priv_data; + uint32_t crc; int ret; ret = ff_bsf_get_packet_ref(ctx, pkt); if (ret < 0) return ret; + crc = av_adler32_update(0, pkt->data, pkt->size); av_log(ctx, AV_LOG_INFO, "n:%7"PRIu64" " "size:%7d " "pts:%s pt:%s " "dts:%s dt:%s " "ds:%"PRId64" d:%s " + "0x%08"PRIx32, priv->nb_packets, pkt->size, av_ts2str(pkt->pts), av_ts2timestr(pkt->pts, &ctx->time_base_in), av_ts2str(pkt->dts), av_ts2timestr(pkt->dts, &ctx->time_base_in), - pkt->duration, av_ts2timestr(pkt->duration, &ctx->time_base_in)); + pkt->duration, av_ts2timestr(pkt->duration, &ctx->time_base_in), crc); if (pkt->flags != AV_PKT_FLAG_KEY) av_log(ctx, AV_LOG_INFO, ", F=0x%0X", pkt->flags); if (pkt->side_data_elems) {
Signed-off-by: James Almer <jamrial@gmail.com> --- libavcodec/bsf/showinfo.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)