diff mbox series

[FFmpeg-devel,v3,1/3] avutil/utils: Allow "!" in FourCCs

Message ID 20240718104757.2809396-2-ffmpeg-devel@pileofstuff.org
State New
Headers show
Series Protect against undocumented error codes | expand

Commit Message

Andrew Sayers July 18, 2024, 10:46 a.m. UTC 
For example, AVERROR_BUG is "BUG!"
---
 libavutil/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol July 18, 2024, 3:42 p.m. UTC | #1 
On Thu, Jul 18, 2024 at 12:48 PM Andrew Sayers <ffmpeg-devel@pileofstuff.org>
wrote:

> For example, AVERROR_BUG is "BUG!"
> ---
>  libavutil/utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/utils.c b/libavutil/utils.c
> index 94d247bbee..a94589e873 100644
> --- a/libavutil/utils.c
> +++ b/libavutil/utils.c
> @@ -81,7 +81,7 @@ char *av_fourcc_make_string(char *buf, uint32_t fourcc)
>          const int print_chr = (c >= '0' && c <= '9') ||
>                                (c >= 'a' && c <= 'z') ||
>                                (c >= 'A' && c <= 'Z') ||
> -                              (c && strchr(". -_", c));
> +                              (c && strchr(". -_!", c));
>          const int len = snprintf(buf, buf_size, print_chr ? "%c" :
> "[%d]", c);
>          if (len < 0)
>              break;
> --
> 2.45.2
>
>
Are FourCC alowed to have "!" ?


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

diff --git a/libavutil/utils.c b/libavutil/utils.c
index 94d247bbee..a94589e873 100644
--- a/libavutil/utils.c
+++ b/libavutil/utils.c
@@ -81,7 +81,7 @@  char *av_fourcc_make_string(char *buf, uint32_t fourcc)
         const int print_chr = (c >= '0' && c <= '9') ||
                               (c >= 'a' && c <= 'z') ||
                               (c >= 'A' && c <= 'Z') ||
-                              (c && strchr(". -_", c));
+                              (c && strchr(". -_!", c));
         const int len = snprintf(buf, buf_size, print_chr ? "%c" : "[%d]", c);
         if (len < 0)
             break;