diff mbox series

[FFmpeg-devel] checkasm: Increase the tolerance for ac3_sum_square_butterfly_float

Message ID 20240723210132.95804-1-martin@martin.st
State New
Headers show
Series [FFmpeg-devel] checkasm: Increase the tolerance for ac3_sum_square_butterfly_float | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Martin Storsjö July 23, 2024, 9:01 p.m. UTC
Increase the tolerance from 10 ulp to 11 ulp. This fixes occasional
errors for some inputs; the errors could be reproduced on
aarch64/neon builds, with "checkasm --test=ac3dsp 3446175925".
---
 tests/checkasm/ac3dsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer July 23, 2024, 9:23 p.m. UTC | #1
On Wed, Jul 24, 2024 at 12:01:32AM +0300, Martin Storsjö via ffmpeg-devel wrote:
> Increase the tolerance from 10 ulp to 11 ulp. This fixes occasional
> errors for some inputs; the errors could be reproduced on
> aarch64/neon builds, with "checkasm --test=ac3dsp 3446175925".
> ---
>  tests/checkasm/ac3dsp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

probably ok

thx

[...]
Martin Storsjö July 24, 2024, 9:13 a.m. UTC | #2
On Tue, 23 Jul 2024, Michael Niedermayer wrote:

> On Wed, Jul 24, 2024 at 12:01:32AM +0300, Martin Storsjö via ffmpeg-devel wrote:
>> Increase the tolerance from 10 ulp to 11 ulp. This fixes occasional
>> errors for some inputs; the errors could be reproduced on
>> aarch64/neon builds, with "checkasm --test=ac3dsp 3446175925".
>> ---
>>  tests/checkasm/ac3dsp.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> probably ok

Thanks, pushed it now.

// Martin
diff mbox series

Patch

diff --git a/tests/checkasm/ac3dsp.c b/tests/checkasm/ac3dsp.c
index 442e965f3b..8c682d03cd 100644
--- a/tests/checkasm/ac3dsp.c
+++ b/tests/checkasm/ac3dsp.c
@@ -181,7 +181,7 @@  static void check_ac3_sum_square_butterfly_float(AC3DSPContext *c) {
         call_ref(v1, lt, rt, ELEMS);
         call_new(v2, lt, rt, ELEMS);
 
-        if (!float_near_ulp_array(v1, v2, 10, 4))
+        if (!float_near_ulp_array(v1, v2, 11, 4))
             fail();
 
         bench_new(v2, lt, rt, ELEMS);