| Message ID | 20241014134714.1210-1-jamrial@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/3] fate/vcodec: stop using the deprecated v308 codec | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/commit_msg_loongarch64 | warning | Please wrap lines in the body of the commit message between 60 and 72 characters. |
Quoting James Almer (2024-10-14 15:47:12) > stddev and PSNR values change by the removal of format conversion and because > of the added sws_flags. Either or will have the same effect even on their own. > > Signed-off-by: James Almer <jamrial@gmail.com> > --- > We could alternatively just remove this test as it will become a duplicate of > the filter-pixdesc one, given it's using rawvideo with an specific pixel format > and not an specific decode/encoder combination. Seems rather backwards to have a fuzzy test that enforces a bitexact result.
On 10/14/2024 11:59 AM, Anton Khirnov wrote: > Quoting James Almer (2024-10-14 15:47:12) >> stddev and PSNR values change by the removal of format conversion and because >> of the added sws_flags. Either or will have the same effect even on their own. >> >> Signed-off-by: James Almer <jamrial@gmail.com> >> --- >> We could alternatively just remove this test as it will become a duplicate of >> the filter-pixdesc one, given it's using rawvideo with an specific pixel format >> and not an specific decode/encoder combination. > > Seems rather backwards to have a fuzzy test that enforces a bitexact > result. The sws_flag bitexact is added with or without my changes. I merely copied the enforced ones from the v408 test which adds neighbor, making it give better results (stddev 0).
diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak index 17648aef59..99a0e0a75f 100644 --- a/tests/fate/vcodec.mak +++ b/tests/fate/vcodec.mak @@ -446,7 +446,10 @@ FATE_VCODEC_SCALE-$(call ENCDEC, R210, AVI) += r210 FATE_VCODEC_SCALE-$(call ENCDEC, V210, AVI) += v210 v210-10 fate-vsynth%-v210-10: ENCOPTS = -pix_fmt yuv422p10 -FATE_VCODEC_SCALE-$(call ENCDEC, V308, AVI) += v308 +FATE_VCODEC_SCALE-$(call ENCDEC, RAWVIDEO, AVI) += v308 +fate-vsynth%-v308: ENCOPTS = -pix_fmt vyu444 -sws_flags neighbor+bitexact +fate-vsynth%-v308: DECOPTS = -sws_flags neighbor+bitexact +fate-vsynth%-v308: CODEC = rawvideo FATE_VCODEC_SCALE-$(call ENCDEC, V408, AVI) += v408 fate-vsynth%-v408: ENCOPTS = -sws_flags neighbor+bitexact diff --git a/tests/ref/vsynth/vsynth1-v308 b/tests/ref/vsynth/vsynth1-v308 index 162624e286..08b333a19d 100644 --- a/tests/ref/vsynth/vsynth1-v308 +++ b/tests/ref/vsynth/vsynth1-v308 @@ -1,4 +1,4 @@ -5d868b73c554a9a2422d6c8a18ce9c02 *tests/data/fate/vsynth1-v308.avi +d120a92e5b3e2a2e728e60de70ad20a1 *tests/data/fate/vsynth1-v308.avi 15213252 tests/data/fate/vsynth1-v308.avi -10fb42f1abf40a289c3edafc0390482c *tests/data/fate/vsynth1-v308.out.rawvideo -stddev: 2.67 PSNR: 39.60 MAXDIFF: 43 bytes: 7603200/ 7603200 +c5ccac874dbf808e9088bc3107860042 *tests/data/fate/vsynth1-v308.out.rawvideo +stddev: 0.00 PSNR:999.99 MAXDIFF: 0 bytes: 7603200/ 7603200 diff --git a/tests/ref/vsynth/vsynth2-v308 b/tests/ref/vsynth/vsynth2-v308 index cc36d8a3a1..2eac7e4bf0 100644 --- a/tests/ref/vsynth/vsynth2-v308 +++ b/tests/ref/vsynth/vsynth2-v308 @@ -1,4 +1,4 @@ -866fb5095976d62279c402023526d7a9 *tests/data/fate/vsynth2-v308.avi +a6fbe366dd280b58b03483cd8d77e420 *tests/data/fate/vsynth2-v308.avi 15213252 tests/data/fate/vsynth2-v308.avi -8394327c14ef0b6fbaae3b69fcc5572a *tests/data/fate/vsynth2-v308.out.rawvideo -stddev: 0.50 PSNR: 54.10 MAXDIFF: 13 bytes: 7603200/ 7603200 +36d7ca943916e1743cefa609eba0205c *tests/data/fate/vsynth2-v308.out.rawvideo +stddev: 0.00 PSNR:999.99 MAXDIFF: 0 bytes: 7603200/ 7603200 diff --git a/tests/ref/vsynth/vsynth3-v308 b/tests/ref/vsynth/vsynth3-v308 index b823c7bad4..cf22d1a8ea 100644 --- a/tests/ref/vsynth/vsynth3-v308 +++ b/tests/ref/vsynth/vsynth3-v308 @@ -1,4 +1,4 @@ -e1259287375d05431ee718e50eb7f37b *tests/data/fate/vsynth3-v308.avi +0bef1dd0d2904b1c40b1e7db1a4dba64 *tests/data/fate/vsynth3-v308.avi 180252 tests/data/fate/vsynth3-v308.avi -02a85ec07377df6b483281038f8882ee *tests/data/fate/vsynth3-v308.out.rawvideo -stddev: 3.06 PSNR: 38.40 MAXDIFF: 40 bytes: 86700/ 86700 +a038ad7c3c09f776304ef7accdea9c74 *tests/data/fate/vsynth3-v308.out.rawvideo +stddev: 0.00 PSNR:999.99 MAXDIFF: 0 bytes: 86700/ 86700 diff --git a/tests/ref/vsynth/vsynth_lena-v308 b/tests/ref/vsynth/vsynth_lena-v308 index 81766df82f..5b85204be7 100644 --- a/tests/ref/vsynth/vsynth_lena-v308 +++ b/tests/ref/vsynth/vsynth_lena-v308 @@ -1,4 +1,4 @@ -eabb002088244fa802b67aea78271641 *tests/data/fate/vsynth_lena-v308.avi +8a8243cac9fd5e5b7d7b4c48615b2b04 *tests/data/fate/vsynth_lena-v308.avi 15213252 tests/data/fate/vsynth_lena-v308.avi -d43cb310c130c69214332d74f6ee5f9a *tests/data/fate/vsynth_lena-v308.out.rawvideo -stddev: 0.41 PSNR: 55.80 MAXDIFF: 7 bytes: 7603200/ 7603200 +dde5895817ad9d219f79a52d0bdfb001 *tests/data/fate/vsynth_lena-v308.out.rawvideo +stddev: 0.00 PSNR:999.99 MAXDIFF: 0 bytes: 7603200/ 7603200
stddev and PSNR values change by the removal of format conversion and because of the added sws_flags. Either or will have the same effect even on their own. Signed-off-by: James Almer <jamrial@gmail.com> --- We could alternatively just remove this test as it will become a duplicate of the filter-pixdesc one, given it's using rawvideo with an specific pixel format and not an specific decode/encoder combination. tests/fate/vcodec.mak | 5 ++++- tests/ref/vsynth/vsynth1-v308 | 6 +++--- tests/ref/vsynth/vsynth2-v308 | 6 +++--- tests/ref/vsynth/vsynth3-v308 | 6 +++--- tests/ref/vsynth/vsynth_lena-v308 | 6 +++--- 5 files changed, 16 insertions(+), 13 deletions(-)