diff mbox series

[FFmpeg-devel] Add SMC vsynth tests

Message ID 288529275472e41c3563cf7e59c00bb8cb34a584.camel@haerdin.se
State New
Headers show
Series [FFmpeg-devel] Add SMC vsynth tests | expand

Checks

Context Check Description
andriy/commit_msg_x86 warning The first line of the commit message must start with a context terminated by a colon and a space, for example "lavu/opt: " or "doc: ".
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed

Commit Message

Tomas Härdin July 2, 2023, 3:28 p.m. UTC

Comments

James Almer July 2, 2023, 3:49 p.m. UTC | #1
On 7/2/2023 12:28 PM, Tomas Härdin wrote:
> 
> ---
>  tests/fate/vcodec.mak            | 3 +++
>  tests/ref/vsynth/vsynth1-smc     | 4 ++++
>  tests/ref/vsynth/vsynth2-smc     | 4 ++++
>  tests/ref/vsynth/vsynth3-smc     | 4 ++++
>  tests/ref/vsynth/vsynth_lena-smc | 4 ++++
>  5 files changed, 19 insertions(+)
>  create mode 100644 tests/ref/vsynth/vsynth1-smc
>  create mode 100644 tests/ref/vsynth/vsynth2-smc
>  create mode 100644 tests/ref/vsynth/vsynth3-smc
>  create mode 100644 tests/ref/vsynth/vsynth_lena-smc
> 
> diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
> index ef8904613a..833dde86ab 100644
> --- a/tests/fate/vcodec.mak
> +++ b/tests/fate/vcodec.mak
> @@ -404,6 +404,9 @@ FATE_VCODEC-$(call ENCDEC, RV20, RM)    += rv20
>  fate-vsynth%-rv20:               ENCOPTS = -qscale 10
>  fate-vsynth%-rv20:               FMT     = rm
>  
> +FATE_VCODEC_SCALE-$(call ENCDEC, SMC, MOV) += smc
> +fate-vsynth%-smc:                CODEC   = smc

Missing a FMT = mp4 line (or mov if smc is supported in it).
Tomas Härdin July 2, 2023, 4:36 p.m. UTC | #2
sön 2023-07-02 klockan 12:49 -0300 skrev James Almer:
> On 7/2/2023 12:28 PM, Tomas Härdin wrote:
> > 
> > ---
> >  tests/fate/vcodec.mak            | 3 +++
> >  tests/ref/vsynth/vsynth1-smc     | 4 ++++
> >  tests/ref/vsynth/vsynth2-smc     | 4 ++++
> >  tests/ref/vsynth/vsynth3-smc     | 4 ++++
> >  tests/ref/vsynth/vsynth_lena-smc | 4 ++++
> >  5 files changed, 19 insertions(+)
> >  create mode 100644 tests/ref/vsynth/vsynth1-smc
> >  create mode 100644 tests/ref/vsynth/vsynth2-smc
> >  create mode 100644 tests/ref/vsynth/vsynth3-smc
> >  create mode 100644 tests/ref/vsynth/vsynth_lena-smc
> > 
> > diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
> > index ef8904613a..833dde86ab 100644
> > --- a/tests/fate/vcodec.mak
> > +++ b/tests/fate/vcodec.mak
> > @@ -404,6 +404,9 @@ FATE_VCODEC-$(call ENCDEC, RV20, RM)    += rv20
> >  fate-vsynth%-rv20:               ENCOPTS = -qscale 10
> >  fate-vsynth%-rv20:               FMT     = rm
> >  
> > +FATE_VCODEC_SCALE-$(call ENCDEC, SMC, MOV) += smc
> > +fate-vsynth%-smc:                CODEC   = smc
> 
> Missing a FMT = mp4 line (or mov if smc is supported in it).

It already says MOV in the call, and mp4 doesn't support SMC

/Tomas
Tomas Härdin July 2, 2023, 4:39 p.m. UTC | #3
sön 2023-07-02 klockan 18:36 +0200 skrev Tomas Härdin:
> sön 2023-07-02 klockan 12:49 -0300 skrev James Almer:
> > On 7/2/2023 12:28 PM, Tomas Härdin wrote:
> > > 
> > > ---
> > >  tests/fate/vcodec.mak            | 3 +++
> > >  tests/ref/vsynth/vsynth1-smc     | 4 ++++
> > >  tests/ref/vsynth/vsynth2-smc     | 4 ++++
> > >  tests/ref/vsynth/vsynth3-smc     | 4 ++++
> > >  tests/ref/vsynth/vsynth_lena-smc | 4 ++++
> > >  5 files changed, 19 insertions(+)
> > >  create mode 100644 tests/ref/vsynth/vsynth1-smc
> > >  create mode 100644 tests/ref/vsynth/vsynth2-smc
> > >  create mode 100644 tests/ref/vsynth/vsynth3-smc
> > >  create mode 100644 tests/ref/vsynth/vsynth_lena-smc
> > > 
> > > diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
> > > index ef8904613a..833dde86ab 100644
> > > --- a/tests/fate/vcodec.mak
> > > +++ b/tests/fate/vcodec.mak
> > > @@ -404,6 +404,9 @@ FATE_VCODEC-$(call ENCDEC, RV20, RM)    +=
> > > rv20
> > >  fate-vsynth%-rv20:               ENCOPTS = -qscale 10
> > >  fate-vsynth%-rv20:               FMT     = rm
> > >  
> > > +FATE_VCODEC_SCALE-$(call ENCDEC, SMC, MOV) += smc
> > > +fate-vsynth%-smc:                CODEC   = smc
> > 
> > Missing a FMT = mp4 line (or mov if smc is supported in it).
> 
> It already says MOV in the call, and mp4 doesn't support SMC

Oh wait the MOV is just for deps I guess, not the actual format output.
Updated patch attached

/Tomas
Paul B Mahol July 2, 2023, 6:57 p.m. UTC | #4
On Sun, Jul 2, 2023 at 6:39 PM Tomas Härdin <git@haerdin.se> wrote:

> sön 2023-07-02 klockan 18:36 +0200 skrev Tomas Härdin:
> > sön 2023-07-02 klockan 12:49 -0300 skrev James Almer:
> > > On 7/2/2023 12:28 PM, Tomas Härdin wrote:
> > > >
> > > > ---
> > > >  tests/fate/vcodec.mak            | 3 +++
> > > >  tests/ref/vsynth/vsynth1-smc     | 4 ++++
> > > >  tests/ref/vsynth/vsynth2-smc     | 4 ++++
> > > >  tests/ref/vsynth/vsynth3-smc     | 4 ++++
> > > >  tests/ref/vsynth/vsynth_lena-smc | 4 ++++
> > > >  5 files changed, 19 insertions(+)
> > > >  create mode 100644 tests/ref/vsynth/vsynth1-smc
> > > >  create mode 100644 tests/ref/vsynth/vsynth2-smc
> > > >  create mode 100644 tests/ref/vsynth/vsynth3-smc
> > > >  create mode 100644 tests/ref/vsynth/vsynth_lena-smc
> > > >
> > > > diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
> > > > index ef8904613a..833dde86ab 100644
> > > > --- a/tests/fate/vcodec.mak
> > > > +++ b/tests/fate/vcodec.mak
> > > > @@ -404,6 +404,9 @@ FATE_VCODEC-$(call ENCDEC, RV20, RM)    +=
> > > > rv20
> > > >  fate-vsynth%-rv20:               ENCOPTS = -qscale 10
> > > >  fate-vsynth%-rv20:               FMT     = rm
> > > >
> > > > +FATE_VCODEC_SCALE-$(call ENCDEC, SMC, MOV) += smc
> > > > +fate-vsynth%-smc:                CODEC   = smc
> > >
> > > Missing a FMT = mp4 line (or mov if smc is supported in it).
> >
> > It already says MOV in the call, and mp4 doesn't support SMC
>
> Oh wait the MOV is just for deps I guess, not the actual format output.
> Updated patch attached
>

LGTM
Feel free to push if it passes tests.


>
> /Tomas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Tomas Härdin July 2, 2023, 7:17 p.m. UTC | #5
sön 2023-07-02 klockan 20:57 +0200 skrev Paul B Mahol:
> On Sun, Jul 2, 2023 at 6:39 PM Tomas Härdin <git@haerdin.se> wrote:
> 
> > sön 2023-07-02 klockan 18:36 +0200 skrev Tomas Härdin:
> > > sön 2023-07-02 klockan 12:49 -0300 skrev James Almer:
> > > > On 7/2/2023 12:28 PM, Tomas Härdin wrote:
> > > > > 
> > > > > ---
> > > > >  tests/fate/vcodec.mak            | 3 +++
> > > > >  tests/ref/vsynth/vsynth1-smc     | 4 ++++
> > > > >  tests/ref/vsynth/vsynth2-smc     | 4 ++++
> > > > >  tests/ref/vsynth/vsynth3-smc     | 4 ++++
> > > > >  tests/ref/vsynth/vsynth_lena-smc | 4 ++++
> > > > >  5 files changed, 19 insertions(+)
> > > > >  create mode 100644 tests/ref/vsynth/vsynth1-smc
> > > > >  create mode 100644 tests/ref/vsynth/vsynth2-smc
> > > > >  create mode 100644 tests/ref/vsynth/vsynth3-smc
> > > > >  create mode 100644 tests/ref/vsynth/vsynth_lena-smc
> > > > > 
> > > > > diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
> > > > > index ef8904613a..833dde86ab 100644
> > > > > --- a/tests/fate/vcodec.mak
> > > > > +++ b/tests/fate/vcodec.mak
> > > > > @@ -404,6 +404,9 @@ FATE_VCODEC-$(call ENCDEC, RV20, RM)   
> > > > > +=
> > > > > rv20
> > > > >  fate-vsynth%-rv20:               ENCOPTS = -qscale 10
> > > > >  fate-vsynth%-rv20:               FMT     = rm
> > > > > 
> > > > > +FATE_VCODEC_SCALE-$(call ENCDEC, SMC, MOV) += smc
> > > > > +fate-vsynth%-smc:                CODEC   = smc
> > > > 
> > > > Missing a FMT = mp4 line (or mov if smc is supported in it).
> > > 
> > > It already says MOV in the call, and mp4 doesn't support SMC
> > 
> > Oh wait the MOV is just for deps I guess, not the actual format
> > output.
> > Updated patch attached
> > 
> 
> LGTM
> Feel free to push if it passes tests.

Passes FATE -> pushed

/Tomas
diff mbox series

Patch

From 121890df70fe77a646527df71c5a15cb74e24543 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <git@haerdin.se>
Date: Sun, 2 Jul 2023 16:58:11 +0200
Subject: [PATCH] Add SMC vsynth tests

---
 tests/fate/vcodec.mak            | 3 +++
 tests/ref/vsynth/vsynth1-smc     | 4 ++++
 tests/ref/vsynth/vsynth2-smc     | 4 ++++
 tests/ref/vsynth/vsynth3-smc     | 4 ++++
 tests/ref/vsynth/vsynth_lena-smc | 4 ++++
 5 files changed, 19 insertions(+)
 create mode 100644 tests/ref/vsynth/vsynth1-smc
 create mode 100644 tests/ref/vsynth/vsynth2-smc
 create mode 100644 tests/ref/vsynth/vsynth3-smc
 create mode 100644 tests/ref/vsynth/vsynth_lena-smc

diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
index ef8904613a..833dde86ab 100644
--- a/tests/fate/vcodec.mak
+++ b/tests/fate/vcodec.mak
@@ -404,6 +404,9 @@  FATE_VCODEC-$(call ENCDEC, RV20, RM)    += rv20
 fate-vsynth%-rv20:               ENCOPTS = -qscale 10
 fate-vsynth%-rv20:               FMT     = rm
 
+FATE_VCODEC_SCALE-$(call ENCDEC, SMC, MOV) += smc
+fate-vsynth%-smc:                CODEC   = smc
+
 FATE_VCODEC_SCALE-$(call ENCDEC, SNOW, AVI) += snow snow-hpel
 fate-vsynth%-snow:               ENCOPTS = -qscale 2 -flags +qpel \
                                            -motion_est iter -dia_size 2      \
diff --git a/tests/ref/vsynth/vsynth1-smc b/tests/ref/vsynth/vsynth1-smc
new file mode 100644
index 0000000000..d45b78d72e
--- /dev/null
+++ b/tests/ref/vsynth/vsynth1-smc
@@ -0,0 +1,4 @@ 
+448fbbcb6a311fce9489081925a1df07 *tests/data/fate/vsynth1-smc.avi
+4618210 tests/data/fate/vsynth1-smc.avi
+5af05d8c97257442877c45e9ac412a07 *tests/data/fate/vsynth1-smc.out.rawvideo
+stddev:   82.04 PSNR:  9.85 MAXDIFF:  239 bytes:  7603200/  7603200
diff --git a/tests/ref/vsynth/vsynth2-smc b/tests/ref/vsynth/vsynth2-smc
new file mode 100644
index 0000000000..58d5ceb671
--- /dev/null
+++ b/tests/ref/vsynth/vsynth2-smc
@@ -0,0 +1,4 @@ 
+0deb655a3f142cc128d6bd06b93a4553 *tests/data/fate/vsynth2-smc.avi
+3480126 tests/data/fate/vsynth2-smc.avi
+6d7dc705f762a7ee1f8139cdc99feba6 *tests/data/fate/vsynth2-smc.out.rawvideo
+stddev:  103.76 PSNR:  7.81 MAXDIFF:  228 bytes:  7603200/  7603200
diff --git a/tests/ref/vsynth/vsynth3-smc b/tests/ref/vsynth/vsynth3-smc
new file mode 100644
index 0000000000..cec8995f9e
--- /dev/null
+++ b/tests/ref/vsynth/vsynth3-smc
@@ -0,0 +1,4 @@ 
+bcb01dfa0c66294bf8b367b441dca966 *tests/data/fate/vsynth3-smc.avi
+70446 tests/data/fate/vsynth3-smc.avi
+0293080027cfea20a539a9947c335ca3 *tests/data/fate/vsynth3-smc.out.rawvideo
+stddev:   62.19 PSNR: 12.26 MAXDIFF:  231 bytes:    86700/    86700
diff --git a/tests/ref/vsynth/vsynth_lena-smc b/tests/ref/vsynth/vsynth_lena-smc
new file mode 100644
index 0000000000..647aedf34d
--- /dev/null
+++ b/tests/ref/vsynth/vsynth_lena-smc
@@ -0,0 +1,4 @@ 
+ce75739815134bdfc68fce38d8ea95e8 *tests/data/fate/vsynth_lena-smc.avi
+3507608 tests/data/fate/vsynth_lena-smc.avi
+7c756aa5cc4e7983259e830d2024050c *tests/data/fate/vsynth_lena-smc.out.rawvideo
+stddev:   77.95 PSNR: 10.29 MAXDIFF:  221 bytes:  7603200/  7603200
-- 
2.39.2