diff mbox

[FFmpeg-devel] lavc/snow_dwt: add missing header for MpegEncContext.

Message ID 456cd942-9cef-b9f8-f7f9-056c00925064@gmail.com
State New
Headers show

Commit Message

Jun Zhao Jan. 16, 2018, 12:16 a.m. UTC 
From ec98c088e138721d33fc8b15b8382981886d4571 Mon Sep 17 00:00:00 2001
From: Jun Zhao <jun.zhao@intel.com>
Date: Mon, 15 Jan 2018 18:57:33 +0800
Subject: [PATCH] lavc/snow_dwt: add missing header for MpegEncContext.

add missing header for MpegEncContext, use make checkheaders
found this issue.

Signed-off-by: Jun Zhao <jun.zhao@intel.com>
---
 libavcodec/snow_dwt.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Michael Niedermayer Jan. 16, 2018, 2:26 a.m. UTC | #1 
On Tue, Jan 16, 2018 at 08:16:00AM +0800, Jun Zhao wrote:
> 

>  snow_dwt.h |    2 ++
>  1 file changed, 2 insertions(+)
> 6b1e418ba1a48ffd912666d237057dbd5d9b9e81  0001-lavc-snow_dwt-add-missing-header-for-MpegEncContext.patch
> From ec98c088e138721d33fc8b15b8382981886d4571 Mon Sep 17 00:00:00 2001
> From: Jun Zhao <jun.zhao@intel.com>
> Date: Mon, 15 Jan 2018 18:57:33 +0800
> Subject: [PATCH] lavc/snow_dwt: add missing header for MpegEncContext.
> 
> add missing header for MpegEncContext, use make checkheaders
> found this issue.

this only needs something like
"struct MpegEncContext;"

including the whole mpegvideo.h is ugly IMHO

[...]
Jun Zhao Jan. 16, 2018, 2:38 a.m. UTC | #2 
On 2018/1/16 10:26, Michael Niedermayer wrote:
> On Tue, Jan 16, 2018 at 08:16:00AM +0800, Jun Zhao wrote:
>>  snow_dwt.h |    2 ++
>>  1 file changed, 2 insertions(+)
>> 6b1e418ba1a48ffd912666d237057dbd5d9b9e81  0001-lavc-snow_dwt-add-missing-header-for-MpegEncContext.patch
>> From ec98c088e138721d33fc8b15b8382981886d4571 Mon Sep 17 00:00:00 2001
>> From: Jun Zhao <jun.zhao@intel.com>
>> Date: Mon, 15 Jan 2018 18:57:33 +0800
>> Subject: [PATCH] lavc/snow_dwt: add missing header for MpegEncContext.
>>
>> add missing header for MpegEncContext, use make checkheaders
>> found this issue.
> this only needs something like
> "struct MpegEncContext;"
>
> including the whole mpegvideo.h is ugly IMHO
>
> [...]
Ok, will re-submit to follow the review, Thanks.
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
diff mbox

Patch

diff --git a/libavcodec/snow_dwt.h b/libavcodec/snow_dwt.h
index e2d7528056..eee735c16f 100644
--- a/libavcodec/snow_dwt.h
+++ b/libavcodec/snow_dwt.h
@@ -24,6 +24,8 @@ 
 #include <stddef.h>
 #include <stdint.h>
 
+#include "mpegvideo.h"
+
 typedef int DWTELEM;
 typedef short IDWTELEM;