diff mbox series

[FFmpeg-devel] tests/fate/wavpack: add a lossless DSD file

Message ID 50bc0cb3-f2b4-9933-a824-24ce5c96147f@wavpack.com
State New
Headers show
Series [FFmpeg-devel] tests/fate/wavpack: add a lossless DSD file
Related show

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate fail Make fate failed

Commit Message

David Bryant April 18, 2020, 3:36 p.m. UTC
As suggested in another thread, I have created a WavPack DSD test file that exercises all three of the DSD modes (fast, high, and copy).

If someone would be kind enough to add this to the fate suite (in the wavpack/lossless folder) then this patch can go in.

file: wavpack.com/dsd.wv (MD5: 74b2181f3e9829d9a5b98edd037984ac)
decoded MD5 (f32le): a3a88bba95f809025dce01ecb9064091

Thanks!

-David Bryant
From 8e11e2068f1e763c46903d52da6489cb360b8f8e Mon Sep 17 00:00:00 2001
From: David Bryant <david@wavpack.com>
Date: Fri, 17 Apr 2020 15:48:05 -0700
Subject: [PATCH] tests/fate/wavpack: add a lossless DSD file

Signed-off-by: David Bryant <david@wavpack.com>
---
 tests/fate/wavpack.mak              | 3 +++
 tests/ref/fate/wavpack-lossless-dsd | 1 +
 2 files changed, 4 insertions(+)
 create mode 100644 tests/ref/fate/wavpack-lossless-dsd

Comments

Carl Eugen Hoyos April 18, 2020, 4:49 p.m. UTC | #1
Am Sa., 18. Apr. 2020 um 17:36 Uhr schrieb David Bryant <david@wavpack.com>:
>
> As suggested in another thread, I have created a WavPack DSD test file that exercises all three of the DSD modes (fast, high, and copy).
>
> If someone would be kind enough to add this to the fate suite (in the wavpack/lossless folder) then this patch can go in.
>
> file: wavpack.com/dsd.wv (MD5: 74b2181f3e9829d9a5b98edd037984ac)

I uploaded it but I wonder if 1MB wouldn't be enough?

Carl Eugen
David Bryant April 18, 2020, 5:31 p.m. UTC | #2
On 4/18/20 9:49 AM, Carl Eugen Hoyos wrote:
> Am Sa., 18. Apr. 2020 um 17:36 Uhr schrieb David Bryant <david@wavpack.com>:
>> As suggested in another thread, I have created a WavPack DSD test file that exercises all three of the DSD modes (fast, high, and copy).
>>
>> If someone would be kind enough to add this to the fate suite (in the wavpack/lossless folder) then this patch can go in.
>>
>> file: wavpack.com/dsd.wv (MD5: 74b2181f3e9829d9a5b98edd037984ac)
> I uploaded it but I wonder if 1MB wouldn't be enough?

It probably would, but because DSD is so inefficient this file is still only 5 seconds long, and because I combined all three
modes, this is really replacing three files.

If space or bandwidth is a concern, I would rather pare down a few other larger WavPack files. There is one 14 MB file that
really is a waste of space (and takes a long time to decode also).

Kind regards,

David


>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Carl Eugen Hoyos April 18, 2020, 5:32 p.m. UTC | #3
Am Sa., 18. Apr. 2020 um 19:31 Uhr schrieb David Bryant <david@wavpack.com>:
>
> On 4/18/20 9:49 AM, Carl Eugen Hoyos wrote:
> > Am Sa., 18. Apr. 2020 um 17:36 Uhr schrieb David Bryant <david@wavpack.com>:
> >> As suggested in another thread, I have created a WavPack DSD test file that exercises all three of the DSD modes (fast, high, and copy).
> >>
> >> If someone would be kind enough to add this to the fate suite (in the wavpack/lossless folder) then this patch can go in.
> >>
> >> file: wavpack.com/dsd.wv (MD5: 74b2181f3e9829d9a5b98edd037984ac)
> > I uploaded it but I wonder if 1MB wouldn't be enough?
>
> It probably would, but because DSD is so inefficient this file is still only 5 seconds long, and because I combined all three
> modes, this is really replacing three files.

Just asking...

> If space or bandwidth is a concern, I would rather pare down a few other larger WavPack files. There is one 14 MB file that
> really is a waste of space (and takes a long time to decode also).

This is not possible as we also want to run fate with old versions of FFmpeg.

Carl Eugen
David Bryant April 18, 2020, 6:17 p.m. UTC | #4
On 4/18/20 10:32 AM, Carl Eugen Hoyos wrote:
> Am Sa., 18. Apr. 2020 um 19:31 Uhr schrieb David Bryant <david@wavpack.com>:
>> On 4/18/20 9:49 AM, Carl Eugen Hoyos wrote:
>>> Am Sa., 18. Apr. 2020 um 17:36 Uhr schrieb David Bryant <david@wavpack.com>:
>>>> As suggested in another thread, I have created a WavPack DSD test file that exercises all three of the DSD modes (fast, high, and copy).
>>>>
>>>> If someone would be kind enough to add this to the fate suite (in the wavpack/lossless folder) then this patch can go in.
>>>>
>>>> file: wavpack.com/dsd.wv (MD5: 74b2181f3e9829d9a5b98edd037984ac)
>>> I uploaded it but I wonder if 1MB wouldn't be enough?
>> It probably would, but because DSD is so inefficient this file is still only 5 seconds long, and because I combined all three
>> modes, this is really replacing three files.
> Just asking...
>
>> If space or bandwidth is a concern, I would rather pare down a few other larger WavPack files. There is one 14 MB file that
>> really is a waste of space (and takes a long time to decode also).
> This is not possible as we also want to run fate with old versions of FFmpeg.

Oh, right, I had not thought of that.

I guess it could be done if you generate the same MD5 result with a different input file, but that's probably not very useful.

Thanks!


- David Bryant


>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/tests/fate/wavpack.mak b/tests/fate/wavpack.mak
index e3cf4ec..65b54c2 100644
--- a/tests/fate/wavpack.mak
+++ b/tests/fate/wavpack.mak
@@ -20,6 +20,9 @@  fate-wavpack-lossless-32bit: CMD = md5 -i $(TARGET_SAMPLES)/wavpack/lossless/32b
 FATE_WAVPACK-$(call DEMDEC, WV, WAVPACK) += fate-wavpack-lossless-float
 fate-wavpack-lossless-float: CMD = md5 -i $(TARGET_SAMPLES)/wavpack/lossless/32bit_float-partial.wv -f f32le
 
+FATE_WAVPACK-$(call DEMDEC, WV, WAVPACK) += fate-wavpack-lossless-dsd
+fate-wavpack-lossless-dsd: CMD = md5 -i $(TARGET_SAMPLES)/wavpack/lossless/dsd.wv -f f32le
+
 # lossy
 
 FATE_WAVPACK-$(call DEMDEC, WV, WAVPACK) += fate-wavpack-lossy-8bit
diff --git a/tests/ref/fate/wavpack-lossless-dsd b/tests/ref/fate/wavpack-lossless-dsd
new file mode 100644
index 0000000..46ffaf7
--- /dev/null
+++ b/tests/ref/fate/wavpack-lossless-dsd
@@ -0,0 +1 @@ 
+a3a88bba95f809025dce01ecb9064091