diff mbox series

[FFmpeg-devel,1/2] libavformat/http: expose actual Location header value

Message ID 5ed42c88-00bd-4db9-a5c8-3c33a65b3ac3@nativewaves.com
State New
Headers show
Series [FFmpeg-devel,1/2] libavformat/http: expose actual Location header value | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Michael Riedl Sept. 19, 2023, 8:52 a.m. UTC
This is needed for muxers which need to access the Location header as transmitted when no redirection happen.

Signed-off-by: Michael Riedl <michael.riedl@nativewaves.com>
---
 libavformat/http.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Marvin Scholz Sept. 19, 2023, 9:05 a.m. UTC | #1
On 19 Sep 2023, at 10:52, Michael Riedl wrote:

> This is needed for muxers which need to access the Location header as transmitted when no redirection happen.
>

Why are you sending the same patch over and over to the ML?

If you have new versions of a patchset, reply to the original and change the topic to:

[PATCH v2 1/2] etc...

(You can use the -vN option of git-format-patch/send-email for that.)

Else it is rather frustrating and confusing for people trying to review
your patches…

> Signed-off-by: Michael Riedl <michael.riedl@nativewaves.com>
> ---
>  libavformat/http.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/http.c b/libavformat/http.c
> index c0fe7c36d91..27f9c8e3000 100644
> --- a/libavformat/http.c
> +++ b/libavformat/http.c
> @@ -166,6 +166,7 @@ static const AVOption options[] = {
>      { "basic", "HTTP basic authentication", 0, AV_OPT_TYPE_CONST, { .i64 = HTTP_AUTH_BASIC }, 0, 0, D | E, "auth_type"},
>      { "send_expect_100", "Force sending an Expect: 100-continue header for POST", OFFSET(send_expect_100), AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, E },
>      { "location", "The actual location of the data received", OFFSET(location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },
> +    { "new_location", "The location header value of the data received", OFFSET(new_location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D },
>      { "offset", "initial byte offset", OFFSET(off), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, INT64_MAX, D },
>      { "end_offset", "try to limit the request to bytes preceding this offset", OFFSET(end_off), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, INT64_MAX, D },
>      { "method", "Override the HTTP method or set the expected HTTP method from a client", OFFSET(method), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },
> -- 
> 2.39.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavformat/http.c b/libavformat/http.c
index c0fe7c36d91..27f9c8e3000 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -166,6 +166,7 @@  static const AVOption options[] = {
     { "basic", "HTTP basic authentication", 0, AV_OPT_TYPE_CONST, { .i64 = HTTP_AUTH_BASIC }, 0, 0, D | E, "auth_type"},
     { "send_expect_100", "Force sending an Expect: 100-continue header for POST", OFFSET(send_expect_100), AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, E },
     { "location", "The actual location of the data received", OFFSET(location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },
+    { "new_location", "The location header value of the data received", OFFSET(new_location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D },
     { "offset", "initial byte offset", OFFSET(off), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, INT64_MAX, D },
     { "end_offset", "try to limit the request to bytes preceding this offset", OFFSET(end_off), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, INT64_MAX, D },
     { "method", "Override the HTTP method or set the expected HTTP method from a client", OFFSET(method), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },