diff mbox series

[FFmpeg-devel] avformat/mxfenc: fix static building

Message ID 77080e9b-f79d-429c-82b8-e3328f8cb3da@nativewaves.com
State Accepted
Commit 721857483f3410cd96e5ec2ec78dade65db83f20
Headers show
Series [FFmpeg-devel] avformat/mxfenc: fix static building | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Michael Riedl Sept. 19, 2023, 3:12 p.m. UTC 
MXF muxer requires rangecoder otherwise static linking fails.

Signed-off-by: Michael Riedl <michael.riedl@nativewaves.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tomas Härdin Sept. 28, 2023, 11:19 a.m. UTC | #1 
tis 2023-09-19 klockan 17:12 +0200 skrev Michael Riedl:
> MXF muxer requires rangecoder otherwise static linking fails.
> 
> Signed-off-by: Michael Riedl <michael.riedl@nativewaves.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 3bb68d3f20c..9d4297ea68f 100755
> --- a/configure
> +++ b/configure
> @@ -3532,7 +3532,7 @@ mp4_muxer_select="mov_muxer"
>  mpegts_demuxer_select="iso_media"
>  mpegts_muxer_select="ac3_parser adts_muxer latm_muxer
> h264_mp4toannexb_bsf hevc_mp4toannexb_bsf"
>  mpegtsraw_demuxer_select="mpegts_demuxer"
> -mxf_muxer_select="pcm_rechunk_bsf"
> +mxf_muxer_select="pcm_rechunk_bsf rangecoder"
>  mxf_d10_muxer_select="mxf_muxer"
>  mxf_opatom_muxer_select="mxf_muxer"
>  nut_muxer_select="riffenc"

Seems like this is for FFV1 parsing. Looks OK.

/Tomas
Michael Riedl Oct. 9, 2023, 8:21 a.m. UTC | #2 
On 9/19/23 17:12, Michael Riedl wrote:
> MXF muxer requires rangecoder otherwise static linking fails.
>
> Signed-off-by: Michael Riedl <michael.riedl@nativewaves.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 3bb68d3f20c..9d4297ea68f 100755
> --- a/configure
> +++ b/configure
> @@ -3532,7 +3532,7 @@ mp4_muxer_select="mov_muxer"
>  mpegts_demuxer_select="iso_media"
>  mpegts_muxer_select="ac3_parser adts_muxer latm_muxer h264_mp4toannexb_bsf hevc_mp4toannexb_bsf"
>  mpegtsraw_demuxer_select="mpegts_demuxer"
> -mxf_muxer_select="pcm_rechunk_bsf"
> +mxf_muxer_select="pcm_rechunk_bsf rangecoder"
>  mxf_d10_muxer_select="mxf_muxer"
>  mxf_opatom_muxer_select="mxf_muxer"
>  nut_muxer_select="riffenc"

Ping. Without this patch master fails to build when ffv1 is not enabled.
Tomas Härdin Oct. 17, 2023, 12:46 p.m. UTC | #3 
tis 2023-09-19 klockan 17:12 +0200 skrev Michael Riedl:
> MXF muxer requires rangecoder otherwise static linking fails.
> 
> Signed-off-by: Michael Riedl <michael.riedl@nativewaves.com>

Pushed

/Tomas
diff mbox series

Patch

diff --git a/configure b/configure
index 3bb68d3f20c..9d4297ea68f 100755
--- a/configure
+++ b/configure
@@ -3532,7 +3532,7 @@  mp4_muxer_select="mov_muxer"
 mpegts_demuxer_select="iso_media"
 mpegts_muxer_select="ac3_parser adts_muxer latm_muxer h264_mp4toannexb_bsf hevc_mp4toannexb_bsf"
 mpegtsraw_demuxer_select="mpegts_demuxer"
-mxf_muxer_select="pcm_rechunk_bsf"
+mxf_muxer_select="pcm_rechunk_bsf rangecoder"
 mxf_d10_muxer_select="mxf_muxer"
 mxf_opatom_muxer_select="mxf_muxer"
 nut_muxer_select="riffenc"