diff mbox series

[FFmpeg-devel] V2 tests/fate/filter-audio.mak: add test for ATEMPO audio filter

Message ID 8cce4088-95f1-4875-b8ef-95a6360428f6@gmail.com
State New
Headers show
Series [FFmpeg-devel] V2 tests/fate/filter-audio.mak: add test for ATEMPO audio filter | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Rajiv Harlalka March 21, 2024, 10:13 a.m. UTC 
Please find an updated patch for tests on the atempo audio filter

Comments

Rajiv Harlalka March 26, 2024, 9:51 p.m. UTC | #1 
On Thu, 21 Mar 2024 at 3:43 PM, Rajiv Harlalka <rajivharlalka009@gmail.com>
wrote:

> Please find an updated patch for tests on the atempo audio filter
>
Bumping this patch up for visibility.
Anton Khirnov March 28, 2024, 8:22 a.m. UTC | #2 
Quoting Rajiv Harlalka (2024-03-21 11:13:46)
> Please find an updated patch for tests on the atempo audio filter
> 
> From 30475d6f076d5236ee534002fffb01958ef0dfc1 Mon Sep 17 00:00:00 2001
> From: Rajiv Harlalka <rajivharlalka009@gmail.com>
> Date: Thu, 21 Mar 2024 13:35:29 +0530
> Subject: [PATCH v2] tests/fate/filter-audio.mak: add test for ATEMPO audio
>  filter
> 
> Signed-off-by: Rajiv Harlalka <rajivharlalka009@gmail.com>
> ---
>  tests/fate/filter-audio.mak  |  3 ++
>  tests/ref/fate/filter-atempo | 70 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 73 insertions(+)
>  create mode 100644 tests/ref/fate/filter-atempo
> 
> diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak
> index 308969c4ac..469c784e87 100644
> --- a/tests/fate/filter-audio.mak
> +++ b/tests/fate/filter-audio.mak
> @@ -414,6 +414,9 @@ fate-filter-hdcd-s32p: CMD = md5 -i $(SRC) -af hdcd -f s32le
>  fate-filter-hdcd-s32p: CMP = oneline
>  fate-filter-hdcd-s32p: REF = 0c5513e83eedaa10ab6fac9ddc173cf5
>  
> +FATE_AFILTER_SAMPLES-$(call FILTERDEMDECENCMUX, ATEMPO, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-atempo
> +fate-filter-atempo: CMD = framecrc -i $(TARGET_PATH)/tests/data/asynth-44100-1.wav -af "atempo=2.0" -ar 44100

atempo uses floats for processing, are you sure this will produce
exactly the same results everywhere?
Rajiv Harlalka March 28, 2024, 8:47 p.m. UTC | #3 
On Thu, 28 Mar 2024 at 1:52 PM, Anton Khirnov <anton@khirnov.net> wrote:

>
> atempo uses floats for processing, are you sure this > will produce
> > exactly the same results everywhere?


Tried replicating in some available environments I had and it worked fine,
though could not relate with the test not working because of floats.

>
diff mbox series

Patch

From 30475d6f076d5236ee534002fffb01958ef0dfc1 Mon Sep 17 00:00:00 2001
From: Rajiv Harlalka <rajivharlalka009@gmail.com>
Date: Thu, 21 Mar 2024 13:35:29 +0530
Subject: [PATCH v2] tests/fate/filter-audio.mak: add test for ATEMPO audio
 filter

Signed-off-by: Rajiv Harlalka <rajivharlalka009@gmail.com>
---
 tests/fate/filter-audio.mak  |  3 ++
 tests/ref/fate/filter-atempo | 70 ++++++++++++++++++++++++++++++++++++
 2 files changed, 73 insertions(+)
 create mode 100644 tests/ref/fate/filter-atempo

diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak
index 308969c4ac..469c784e87 100644
--- a/tests/fate/filter-audio.mak
+++ b/tests/fate/filter-audio.mak
@@ -414,6 +414,9 @@  fate-filter-hdcd-s32p: CMD = md5 -i $(SRC) -af hdcd -f s32le
 fate-filter-hdcd-s32p: CMP = oneline
 fate-filter-hdcd-s32p: REF = 0c5513e83eedaa10ab6fac9ddc173cf5
 
+FATE_AFILTER_SAMPLES-$(call FILTERDEMDECENCMUX, ATEMPO, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-atempo
+fate-filter-atempo: CMD = framecrc -i $(TARGET_PATH)/tests/data/asynth-44100-1.wav -af "atempo=2.0" -ar 44100
+
 FATE_AFILTER-yes += fate-filter-formats
 fate-filter-formats: libavfilter/tests/formats$(EXESUF)
 fate-filter-formats: CMD = run libavfilter/tests/formats$(EXESUF)
diff --git a/tests/ref/fate/filter-atempo b/tests/ref/fate/filter-atempo
new file mode 100644
index 0000000000..abedfcd618
--- /dev/null
+++ b/tests/ref/fate/filter-atempo
@@ -0,0 +1,70 @@ 
+#tb 0: 1/44100
+#media_type 0: audio
+#codec_id 0: pcm_s16le
+#sample_rate 0: 44100
+#channel_layout_name 0: mono
+0,          0,          0,     2048,     4096, 0x9c4dffa9
+0,       2048,       2048,     2048,     4096, 0x3a11f3f6
+0,       4096,       4096,     2048,     4096, 0x9835f5a5
+0,       6144,       6144,     2048,     4096, 0x7fe7e8ab
+0,       8192,       8192,     2048,     4096, 0x9450f26b
+0,      10240,      10240,     2048,     4096, 0x8f95ff6a
+0,      12288,      12288,     2048,     4096, 0xc9deebab
+0,      14336,      14336,     2048,     4096, 0x0229ec6c
+0,      16384,      16384,     2048,     4096, 0xb1b00a8c
+0,      18432,      18432,     2048,     4096, 0x43e7f197
+0,      20480,      20480,     2048,     4096, 0x60580ec1
+0,      22528,      22528,     2048,     4096, 0x1a4f084c
+0,      24576,      24576,     2048,     4096, 0x70d20213
+0,      26624,      26624,     2048,     4096, 0xaf9afc70
+0,      28672,      28672,     2048,     4096, 0x1212df6f
+0,      30720,      30720,     2048,     4096, 0x37a8f35a
+0,      32768,      32768,     2048,     4096, 0x4730f0ee
+0,      34816,      34816,     2048,     4096, 0x1fe1efd8
+0,      36864,      36864,     2048,     4096, 0xdfc4149e
+0,      38912,      38912,     2048,     4096, 0xe288ffd1
+0,      40960,      40960,     2048,     4096, 0xee7b0829
+0,      43008,      43008,     2048,     4096, 0xb20df4aa
+0,      45056,      45056,     2048,     4096, 0x0564f254
+0,      47104,      47104,     2048,     4096, 0x92daf362
+0,      49152,      49152,     2048,     4096, 0xaab3f18b
+0,      51200,      51200,     2048,     4096, 0xe2bdfcb4
+0,      53248,      53248,     2048,     4096, 0x706adab4
+0,      55296,      55296,     2048,     4096, 0x141a075b
+0,      57344,      57344,     2048,     4096, 0x87aad71f
+0,      59392,      59392,     2048,     4096, 0xfafd0233
+0,      61440,      61440,     2048,     4096, 0x74b1cb64
+0,      63488,      63488,     2048,     4096, 0x9ffee659
+0,      65536,      65536,     2048,     4096, 0x50dde96c
+0,      67584,      67584,     2048,     4096, 0xa4f5fc36
+0,      69632,      69632,     2048,     4096, 0xd40ff139
+0,      71680,      71680,     2048,     4096, 0xe93fe12a
+0,      73728,      73728,     2048,     4096, 0x747f05da
+0,      75776,      75776,     2048,     4096, 0x902601d7
+0,      77824,      77824,     2048,     4096, 0xee871089
+0,      79872,      79872,     2048,     4096, 0x8fba09ee
+0,      81920,      81920,     2048,     4096, 0x832afdea
+0,      83968,      83968,     2048,     4096, 0x7224ec15
+0,      86016,      86016,     2048,     4096, 0xf7def9f4
+0,      88064,      88064,     2048,     4096, 0x3c8af149
+0,      90112,      90112,     2048,     4096, 0x1dc1dfcf
+0,      92160,      92160,     2048,     4096, 0x8ef51140
+0,      94208,      94208,     2048,     4096, 0x4b200588
+0,      96256,      96256,     2048,     4096, 0x29e9be20
+0,      98304,      98304,     2048,     4096, 0x8298f08a
+0,     100352,     100352,     2048,     4096, 0xae5ef3b3
+0,     102400,     102400,     2048,     4096, 0xa76cfbe3
+0,     104448,     104448,     2048,     4096, 0xf784fdb0
+0,     106496,     106496,     2048,     4096, 0xea70f93e
+0,     108544,     108544,     2048,     4096, 0xea5ffc00
+0,     110592,     110592,     2048,     4096, 0x6c2f0350
+0,     112640,     112640,     2048,     4096, 0x5f94cf81
+0,     114688,     114688,     2048,     4096, 0x2f28fda2
+0,     116736,     116736,     2048,     4096, 0x3db0fc68
+0,     118784,     118784,     2048,     4096, 0x15bc0c1f
+0,     120832,     120832,     2048,     4096, 0x48840656
+0,     122880,     122880,     2048,     4096, 0xdf70ee6e
+0,     124928,     124928,     2048,     4096, 0x2dece83a
+0,     126976,     126976,     2048,     4096, 0x1e52cdf5
+0,     129024,     129024,     2048,     4096, 0x27ebc5af
+0,     131072,     131072,     1368,     2736, 0xebfc5933
-- 
2.44.0