| Message ID | 8d62321a-5a9d-4a3e-9661-8df85bc55247@nativewaves.com |
|---|---|
| State | New |
| Headers | show |
| Series | WebRTC sub-second live streaming support | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Mon, 6 Nov 2023 at 15:19, Michael Riedl <michael.riedl@nativewaves.com> wrote: > Whitespaces after semicolon breaks some servers > Are you sure this patch doesn't break other servers? SDP is a painfully fragile format. Kieran
Le maanantaina 6. marraskuuta 2023, 17.36.18 EET Kieran Kunhya a écrit : > On Mon, 6 Nov 2023 at 15:19, Michael Riedl <michael.riedl@nativewaves.com> > > wrote: > > Whitespaces after semicolon breaks some servers > > Are you sure this patch doesn't break other servers? SDP is a painfully > fragile format. AFAIK, you're not supposed to have white spaces there. They are tolerated by most parsers as they are unambiguously not part of the value, is all.
diff --git a/libavformat/sdp.c b/libavformat/sdp.c index 68889362906..5ab017b1ba5 100644 --- a/libavformat/sdp.c +++ b/libavformat/sdp.c @@ -159,8 +159,8 @@ static int extradata2psets(AVFormatContext *s, const AVCodecParameters *par, { char *psets, *p; const uint8_t *r; - static const char pset_string[] = "; sprop-parameter-sets="; - static const char profile_string[] = "; profile-level-id="; + static const char pset_string[] = ";sprop-parameter-sets="; + static const char profile_string[] = ";profile-level-id="; uint8_t *extradata = par->extradata; int extradata_size = par->extradata_size; uint8_t *tmpbuf = NULL;
Whitespaces after semicolon breaks some servers Signed-off-by: Michael Riedl <michael.riedl@nativewaves.com> --- libavformat/sdp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)