diff mbox series

[FFmpeg-devel,29/38] avfilter/vf_vflip: Remove empty options and AVClass

Message ID AM7PR03MB666005C28495FB2D78626FB18FD89@AM7PR03MB6660.eurprd03.prod.outlook.com
State New
Headers show
Series [FFmpeg-devel,01/39] avfilter/vf_maskedminmax: Simplify init | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Andreas Rheinhardt Sept. 12, 2021, 10:53 a.m. UTC 
This filter only had an AVClass and empty options because up until
recently, avfilter_init_str() errored out when options were provided
for a filter without an AVClass. But setting (generic) options is
necessary to take advantage of timeline support. So with
avfilter_init_str() fixed, the AVClass and the options can be removed.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/vf_vflip.c | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Paul B Mahol Sept. 13, 2021, 11:56 a.m. UTC | #1 
lgtm
diff mbox series

Patch

diff --git a/libavfilter/vf_vflip.c b/libavfilter/vf_vflip.c
index 0d624512f9..c447663c11 100644
--- a/libavfilter/vf_vflip.c
+++ b/libavfilter/vf_vflip.c
@@ -24,24 +24,16 @@ 
  */
 
 #include "libavutil/internal.h"
-#include "libavutil/opt.h"
 #include "libavutil/pixdesc.h"
 #include "avfilter.h"
 #include "internal.h"
 #include "video.h"
 
 typedef struct FlipContext {
-    const AVClass *class;
     int vsub;   ///< vertical chroma subsampling
     int bayer;
 } FlipContext;
 
-static const AVOption vflip_options[] = {
-    { NULL }
-};
-
-AVFILTER_DEFINE_CLASS(vflip);
-
 static int config_input(AVFilterLink *link)
 {
     FlipContext *flip = link->dst->priv;
@@ -146,7 +138,6 @@  const AVFilter ff_vf_vflip = {
     .name        = "vflip",
     .description = NULL_IF_CONFIG_SMALL("Flip the input video vertically."),
     .priv_size   = sizeof(FlipContext),
-    .priv_class  = &vflip_class,
     FILTER_INPUTS(avfilter_vf_vflip_inputs),
     FILTER_OUTPUTS(avfilter_vf_vflip_outputs),
     .flags       = AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC,