diff mbox series

[FFmpeg-devel] fftools/cmdutils: Use av_strstart() instead of strncmp()

Message ID AM7PR03MB6660354B2992574208DE9D608FF79@AM7PR03MB6660.eurprd03.prod.outlook.com
State Accepted
Commit c66bb56d9aa819ff952eb7159d014c7c3265016a
Headers show
Series [FFmpeg-devel] fftools/cmdutils: Use av_strstart() instead of strncmp() | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Aug. 10, 2021, 6:45 p.m. UTC 
This also avoids hardcoding lengths.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
Will apply this tomorrow unless there are objections in order not to
block Soft Works' patch.

 fftools/cmdutils.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 64237a4796..6d0bcd6085 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -903,20 +903,18 @@  int opt_loglevel(void *optctx, const char *opt, const char *arg)
         if (!i && !cmd) {
             flags = 0;  /* missing relative prefix, build absolute value */
         }
-        if (!strncmp(token, "repeat", 6)) {
+        if (av_strstart(token, "repeat", &arg)) {
             if (cmd == '-') {
                 flags |= AV_LOG_SKIP_REPEATED;
             } else {
                 flags &= ~AV_LOG_SKIP_REPEATED;
             }
-            arg = token + 6;
-        } else if (!strncmp(token, "level", 5)) {
+        } else if (av_strstart(token, "level", &arg)) {
             if (cmd == '-') {
                 flags &= ~AV_LOG_PRINT_LEVEL;
             } else {
                 flags |= AV_LOG_PRINT_LEVEL;
             }
-            arg = token + 5;
         } else {
             break;
         }