diff mbox series

[FFmpeg-devel,06/25] avfilter/graphdump: Don't return truncated string

Message ID AM7PR03MB666089DAECA3E964260DE9808FC89@AM7PR03MB6660.eurprd03.prod.outlook.com
State Accepted
Commit 76ff9640bea867a8ae5b7972faddc85eb7476222
Headers show
Series [FFmpeg-devel,01/25] avformat/matroskadec: Fix heap-buffer overflow upon gigantic timestamps | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/configureppc warning Failed to apply patch

Commit Message

Andreas Rheinhardt Aug. 27, 2021, 2:27 p.m. UTC 
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/graphdump.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/libavfilter/graphdump.c b/libavfilter/graphdump.c
index cf3296550c..099125bea8 100644
--- a/libavfilter/graphdump.c
+++ b/libavfilter/graphdump.c
@@ -159,8 +159,10 @@  char *avfilter_graph_dump(AVFilterGraph *graph, const char *options)
 
     av_bprint_init(&buf, 0, AV_BPRINT_SIZE_COUNT_ONLY);
     avfilter_graph_dump_to_buf(&buf, graph);
-    av_bprint_init(&buf, buf.len + 1, buf.len + 1);
+    dump = av_malloc(buf.len + 1);
+    if (!dump)
+        return NULL;
+    av_bprint_init_for_buffer(&buf, dump, buf.len + 1);
     avfilter_graph_dump_to_buf(&buf, graph);
-    av_bprint_finalize(&buf, &dump);
     return dump;
 }