diff mbox series

[FFmpeg-devel,22/27] fate/oma: Add remux tests for ATRAC3 and ATRAC3P

Message ID AM7PR03MB66609D4B05213C73A0409BFB8FA39@AM7PR03MB6660.eurprd03.prod.outlook.com
State Accepted
Commit ffe9867bc22aba87fb016e16a4c628e010f404b3
Headers show
Series [FFmpeg-devel,01/27] avformat/astenc: Simplify writing padding
Related show

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Andreas Rheinhardt Sept. 23, 2021, 3:28 p.m. UTC
They already uncovered an uninitialized-value bug in the ATRAC3 code
in the demuxer; and provide coverage for ID3v2.3.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 tests/fate/oma.mak               | 18 +++++++++++++++++-
 tests/ref/fate/oma-atrac3-remux  | 14 ++++++++++++++
 tests/ref/fate/oma-atrac3p-remux | 18 ++++++++++++++++++
 3 files changed, 49 insertions(+), 1 deletion(-)
 create mode 100644 tests/ref/fate/oma-atrac3-remux
 create mode 100644 tests/ref/fate/oma-atrac3p-remux
diff mbox series

Patch

diff --git a/tests/fate/oma.mak b/tests/fate/oma.mak
index 977dbd5c32..a088feff21 100644
--- a/tests/fate/oma.mak
+++ b/tests/fate/oma.mak
@@ -1,5 +1,21 @@ 
 FATE_OMA_FFMPEG-$(call ALLYES, OMA_DEMUXER CRC_MUXER) += fate-oma-demux
 fate-oma-demux: CMD = crc -i $(TARGET_SAMPLES)/oma/01-Untitled-partial.oma -c:a copy
 
+# Also tests splitting and joining the date into TYER and TDAT id3v2.3 tags.
+FATE_OMA_REMUX_FFPROBE-yes += fate-oma-atrac3p-remux
+fate-oma-atrac3p-remux: CMD = transcode oma $(TARGET_SAMPLES)/atrac3p/at3p_sample1.oma oma "-c copy -metadata date=2021-09-23 -metadata time=16:00 -metadata title=noise -metadata id3v2_priv.foo=hex\xB3 -metadata_header_padding 500" "-c copy -t 0.2" "" "-show_entries format_tags"
+
+FATE_OMA_REMUX-$(CONFIG_WAV_DEMUXER) += fate-oma-atrac3-remux
+fate-oma-atrac3-remux: CMD = transcode wav $(TARGET_SAMPLES)/atrac3/mc_sich_at3_132_small.wav oma "-c copy" "-c copy -t 0.1"
+
+FATE_OMA_FFMPEG-$(call ALLYES, FILE_PROTOCOL OMA_MUXER    \
+                               OMA_DEMUXER FRAMECRC_MUXER \
+                               PIPE_PROTOCOL)             \
+                               += $(FATE_OMA_REMUX-yes)
+FATE_OMA_FFMPEG_FFPROBE-$(call ALLYES, FILE_PROTOCOL OMA_MUXER    \
+                                       OMA_DEMUXER FRAMECRC_MUXER \
+                                       PIPE_PROTOCOL)             \
+                                       += $(FATE_OMA_REMUX_FFPROBE-yes)
 FATE_SAMPLES_FFMPEG         += $(FATE_OMA_FFMPEG-yes)
-fate-oma: $(FATE_OMA_FFMPEG-yes)
+FATE_SAMPLES_FFMPEG_FFPROBE += $(FATE_OMA_FFMPEG_FFPROBE-yes)
+fate-oma: $(FATE_OMA_FFMPEG-yes) $(FATE_OMA_FFMPEG_FFPROBE-yes)
diff --git a/tests/ref/fate/oma-atrac3-remux b/tests/ref/fate/oma-atrac3-remux
new file mode 100644
index 0000000000..fb402c43c6
--- /dev/null
+++ b/tests/ref/fate/oma-atrac3-remux
@@ -0,0 +1,14 @@ 
+9f1825375316cb8d6109747def944856 *tests/data/fate/oma-atrac3-remux.oma
+50056 tests/data/fate/oma-atrac3-remux.oma
+#extradata 0:       14, 0x0aa600f2
+#tb 0: 1/44100
+#media_type 0: audio
+#codec_id 0: atrac3
+#sample_rate 0: 44100
+#channel_layout 0: 3
+#channel_layout_name 0: stereo
+0,          0,          0,     1024,      384, 0xdfded1b5
+0,       1024,       1024,     1024,      384, 0xd8e3badd
+0,       2048,       2048,     1024,      384, 0xa316bdbb
+0,       3072,       3072,     1024,      384, 0xcea0ad2b
+0,       4096,       4096,     1024,      384, 0x88d7a98a
diff --git a/tests/ref/fate/oma-atrac3p-remux b/tests/ref/fate/oma-atrac3p-remux
new file mode 100644
index 0000000000..d909fdaee9
--- /dev/null
+++ b/tests/ref/fate/oma-atrac3p-remux
@@ -0,0 +1,18 @@ 
+0053481795d07598bf2e7d931dfc4fa3 *tests/data/fate/oma-atrac3p-remux.oma
+671783 tests/data/fate/oma-atrac3p-remux.oma
+#tb 0: 1/44100
+#media_type 0: audio
+#codec_id 0: atrac3p
+#sample_rate 0: 44100
+#channel_layout 0: 3
+#channel_layout_name 0: stereo
+0,          0,          0,     2048,     1488, 0x69b7fad9
+0,       2048,       2048,     2048,     1488, 0x3c43fdb8
+0,       4096,       4096,     2048,     1488, 0xdcd2dbcc
+0,       6144,       6144,     2048,     1488, 0x5708e4bd
+0,       8192,       8192,     2048,     1488, 0xdc7bf8a7
+[FORMAT]
+TAG:title=noise
+TAG:time=16:00
+TAG:date=2021-09-23
+[/FORMAT]