diff mbox series

[FFmpeg-devel,5/5] avfilter/af_(afftdn|agate), vf_(guided|morpho): Remove timeline support

Message ID AM7PR03MB6660CA8C6EEEBE397DA550228FAD9@AM7PR03MB6660.eurprd03.prod.outlook.com
State Withdrawn
Headers show
Series [FFmpeg-devel,1/5] avfilter/vf_morpho: Fix leak of output frame on error | expand

Checks

Context Check Description
andriy/configurex86 warning Failed to apply patch
andriy/configureppc warning Failed to apply patch

Commit Message

Andreas Rheinhardt Oct. 3, 2021, 9:48 a.m. UTC 
These filters trigger an av_assert1() in ff_filter_activate().

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/af_afftdn.c | 3 +--
 libavfilter/af_agate.c  | 1 -
 libavfilter/vf_guided.c | 3 +--
 libavfilter/vf_morpho.c | 1 -
 4 files changed, 2 insertions(+), 6 deletions(-)

Comments

Paul B Mahol Oct. 3, 2021, 9:56 a.m. UTC | #1 
NAK, except for maybe guided.
diff mbox series

Patch

diff --git a/libavfilter/af_afftdn.c b/libavfilter/af_afftdn.c
index 5e9cefcfc1..87c6cd2219 100644
--- a/libavfilter/af_afftdn.c
+++ b/libavfilter/af_afftdn.c
@@ -1419,6 +1419,5 @@  const AVFilter ff_af_afftdn = {
     FILTER_INPUTS(inputs),
     FILTER_OUTPUTS(outputs),
     .process_command = process_command,
-    .flags           = AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC |
-                       AVFILTER_FLAG_SLICE_THREADS,
+    .flags           = AVFILTER_FLAG_SLICE_THREADS,
 };
diff --git a/libavfilter/af_agate.c b/libavfilter/af_agate.c
index 5de2cc0f0e..63b4d8e7b5 100644
--- a/libavfilter/af_agate.c
+++ b/libavfilter/af_agate.c
@@ -407,6 +407,5 @@  const AVFilter ff_af_sidechaingate = {
     FILTER_INPUTS(sidechaingate_inputs),
     FILTER_OUTPUTS(sidechaingate_outputs),
     .process_command = ff_filter_process_command,
-    .flags          = AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC,
 };
 #endif  /* CONFIG_SIDECHAINGATE_FILTER */
diff --git a/libavfilter/vf_guided.c b/libavfilter/vf_guided.c
index 6720213219..16a6e9043c 100644
--- a/libavfilter/vf_guided.c
+++ b/libavfilter/vf_guided.c
@@ -494,7 +494,6 @@  const AVFilter ff_vf_guided = {
     .activate        = activate,
     .inputs          = NULL,
     FILTER_OUTPUTS(guided_outputs),
-    .flags           = AVFILTER_FLAG_DYNAMIC_INPUTS | AVFILTER_FLAG_SLICE_THREADS |
-                       AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC,
+    .flags           = AVFILTER_FLAG_DYNAMIC_INPUTS | AVFILTER_FLAG_SLICE_THREADS,
     .process_command = process_command,
 };
diff --git a/libavfilter/vf_morpho.c b/libavfilter/vf_morpho.c
index 818ebd6b9a..d29961f5b7 100644
--- a/libavfilter/vf_morpho.c
+++ b/libavfilter/vf_morpho.c
@@ -1027,6 +1027,5 @@  const AVFilter ff_vf_morpho = {
     .query_formats   = query_formats,
     FILTER_INPUTS(morpho_inputs),
     FILTER_OUTPUTS(morpho_outputs),
-    .flags           = AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC,
     .process_command = ff_filter_process_command,
 };