diff mbox series

[FFmpeg-devel,v3,2/5] avcodec/mmaldec: re-use AVPacket for extra_data

Message ID AM7PR03MB6660EC0A8266F39DC23CAC528F709@AM7PR03MB6660.eurprd03.prod.outlook.com
State Accepted
Commit 6f0e8b998a91f0ad9a260b01d8ff29efdf3321d3
Headers show
Series Switch mmaldec to receive_frame API | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Andreas Rheinhardt Dec. 9, 2021, 1:08 p.m. UTC 
From: Ho Ming Shun <cyph1984@gmail.com>

extra_data and normal packets (from ff_decode_get_packet) processing do
not overlap, thus we can re-use the spare AVPacket to send to
ffmmal_add_packet.

Furthermore, this removes allocation of AVPacket on the stack and stops
using deprecated av_init_packet.

Signed-off-by: Ho Ming Shun <cyph1984@gmail.com>
---
 libavcodec/mmaldec.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c
index d336f10350..68ecc68f17 100644
--- a/libavcodec/mmaldec.c
+++ b/libavcodec/mmaldec.c
@@ -782,12 +782,10 @@  static int ffmmal_receive_frame(AVCodecContext *avctx, AVFrame *frame)
     int got_frame = 0;
 
     if (avctx->extradata_size && !ctx->extradata_sent) {
-        AVPacket pkt = {0};
-        av_init_packet(&pkt);
-        pkt.data = avctx->extradata;
-        pkt.size = avctx->extradata_size;
+        avpkt->data = avctx->extradata;
+        avpkt->size = avctx->extradata_size;
         ctx->extradata_sent = 1;
-        if ((ret = ffmmal_add_packet(avctx, &pkt, 1)) < 0)
+        if ((ret = ffmmal_add_packet(avctx, avpkt, 1)) < 0)
             return ret;
     }