diff mbox series

[FFmpeg-devel] avfilter: Constify non-const filters

Message ID AS1PR01MB956485C3C590A022D8AD6CC88FE09@AS1PR01MB9564.eurprd01.prod.exchangelabs.com
State Accepted
Commit 2b2380c098569af88e7a77aff78f330d11090512
Headers show
Series [FFmpeg-devel] avfilter: Constify non-const filters | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt April 1, 2022, 6:56 p.m. UTC 
This makes the filters match their declaration in
libavfilter/allfilters.c; the earlier discrepancy was btw UB.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/vf_libplacebo.c         | 2 +-
 libavfilter/vf_overlay_vaapi.c      | 2 +-
 libavfilter/vf_siti.c               | 2 +-
 libavfilter/vf_yadif_videotoolbox.m | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

Comments

Paul B Mahol April 1, 2022, 7:02 p.m. UTC | #1 
lgtm
diff mbox series

Patch

diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c
index 8ce6462c66..5bcdd64d84 100644
--- a/libavfilter/vf_libplacebo.c
+++ b/libavfilter/vf_libplacebo.c
@@ -746,7 +746,7 @@  static const AVFilterPad libplacebo_outputs[] = {
     },
 };
 
-AVFilter ff_vf_libplacebo = {
+const AVFilter ff_vf_libplacebo = {
     .name           = "libplacebo",
     .description    = NULL_IF_CONFIG_SMALL("Apply various GPU filters from libplacebo"),
     .priv_size      = sizeof(LibplaceboContext),
diff --git a/libavfilter/vf_overlay_vaapi.c b/libavfilter/vf_overlay_vaapi.c
index 1227a8c4c4..b3a624ae15 100644
--- a/libavfilter/vf_overlay_vaapi.c
+++ b/libavfilter/vf_overlay_vaapi.c
@@ -408,7 +408,7 @@  static const AVFilterPad overlay_vaapi_outputs[] = {
     },
 };
 
-AVFilter ff_vf_overlay_vaapi = {
+const AVFilter ff_vf_overlay_vaapi = {
     .name            = "overlay_vaapi",
     .description     = NULL_IF_CONFIG_SMALL("Overlay one video on top of another"),
     .priv_size       = sizeof(OverlayVAAPIContext),
diff --git a/libavfilter/vf_siti.c b/libavfilter/vf_siti.c
index b0d3d95be2..94cf4e3c5c 100644
--- a/libavfilter/vf_siti.c
+++ b/libavfilter/vf_siti.c
@@ -335,7 +335,7 @@  static const AVFilterPad avfilter_vf_siti_outputs[] = {
     },
 };
 
-AVFilter ff_vf_siti = {
+const AVFilter ff_vf_siti = {
     .name          = "siti",
     .description   = NULL_IF_CONFIG_SMALL("Calculate spatial information (SI) and temporal information (TI)."),
     .priv_size     = sizeof(SiTiContext),
diff --git a/libavfilter/vf_yadif_videotoolbox.m b/libavfilter/vf_yadif_videotoolbox.m
index 455745817f..69186c2254 100644
--- a/libavfilter/vf_yadif_videotoolbox.m
+++ b/libavfilter/vf_yadif_videotoolbox.m
@@ -440,7 +440,7 @@  static const AVFilterPad yadif_videotoolbox_outputs[] = {
     },
 };
 
-AVFilter ff_vf_yadif_videotoolbox = {
+const AVFilter ff_vf_yadif_videotoolbox = {
     .name           = "yadif_videotoolbox",
     .description    = NULL_IF_CONFIG_SMALL("YADIF for VideoToolbox frames using Metal compute"),
     .priv_size      = YADIF_VT_CTX_SIZE,