diff mbox series

[FFmpeg-devel] avformat/mov: Initialize padding of buffer

Message ID AS1PR01MB9564BB5D6C7F3AC6601D7CC58F189@AS1PR01MB9564.eurprd01.prod.exchangelabs.com
State New
Headers show
Series [FFmpeg-devel] avformat/mov: Initialize padding of buffer | expand


Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_aarch64_jetson success Make finished
andriy/make_fate_aarch64_jetson success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_armv7_RPi4 success Make finished
andriy/make_fate_armv7_RPi4 success Make fate finished

Commit Message

Andreas Rheinhardt March 23, 2022, 11:25 a.m. UTC
Fixes ticket #9695.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
No value read from the padding is actually used at all;
Valgrind is smart enough to detect this and not warn about this.
MemorySanitizer is unfortunately not. Do we treat such issues
as real or just close them as false positives?

 libavformat/mov.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series


diff --git a/libavformat/mov.c b/libavformat/mov.c
index 6c847de164..ff2824abad 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -2923,6 +2923,7 @@  static int mov_read_stsz(MOVContext *c, AVIOContext *pb, MOVAtom atom)
         av_log(c->fc, AV_LOG_WARNING, "STSZ atom truncated\n");
         return 0;
+    memset(buf + num_bytes, 0, AV_INPUT_BUFFER_PADDING_SIZE);
     init_get_bits(&gb, buf, 8*num_bytes);