| Message ID | AS8P250MB074409FACB82F7D579C3698E8F02A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM |
|---|---|
| State | Accepted |
| Commit | 096563c1086db8e8ebbb980ef65846b21d1fa010 |
| Headers | show |
| Series | [FFmpeg-devel] avcodec/Makefile: Unconditionally skip vulkan_video_codec_av1std.h | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
Jul 24, 2023, 22:46 by andreas.rheinhardt@outlook.com: > libavcodec/vulkan_video_codec_av1std.h currently does not pass > checkheaders: It is missing stdint.h and vulkan/vulkan_core.h. > The comment "This header is NOT YET generated from the Khronos Vulkan > XML API Registry." as well as the fact that it does not use our standard > inclusion guards makes the file appear as if it is to be treated > like a third-party header and not one of our own. This commit > therefore "fixes" the issue by unconditionally skipping said header. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > --- > libavcodec/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > LGTM Thanks.
diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 9101ab73b4..625a40afb1 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -1282,6 +1282,7 @@ SKIPHEADERS += %_tablegen.h \ aacenc_quantization.h \ aacenc_quantization_misc.h \ bitstream_template.h \ + vulkan_video_codec_av1std.h \ $(ARCH)/vpx_arith.h \ SKIPHEADERS-$(CONFIG_AMF) += amfenc.h @@ -1303,7 +1304,7 @@ SKIPHEADERS-$(CONFIG_XVMC) += xvmc.h SKIPHEADERS-$(CONFIG_VAAPI) += vaapi_decode.h vaapi_hevc.h vaapi_encode.h SKIPHEADERS-$(CONFIG_VDPAU) += vdpau.h vdpau_internal.h SKIPHEADERS-$(CONFIG_VIDEOTOOLBOX) += videotoolbox.h vt_internal.h -SKIPHEADERS-$(CONFIG_VULKAN) += vulkan.h vulkan_video.h vulkan_decode.h vulkan_video_codec_av1std.h vulkan_video_codec_av1std_decode.h +SKIPHEADERS-$(CONFIG_VULKAN) += vulkan.h vulkan_video.h vulkan_decode.h vulkan_video_codec_av1std_decode.h SKIPHEADERS-$(CONFIG_V4L2_M2M) += v4l2_buffers.h v4l2_context.h v4l2_m2m.h SKIPHEADERS-$(CONFIG_ZLIB) += zlib_wrapper.h
libavcodec/vulkan_video_codec_av1std.h currently does not pass checkheaders: It is missing stdint.h and vulkan/vulkan_core.h. The comment "This header is NOT YET generated from the Khronos Vulkan XML API Registry." as well as the fact that it does not use our standard inclusion guards makes the file appear as if it is to be treated like a third-party header and not one of our own. This commit therefore "fixes" the issue by unconditionally skipping said header. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavcodec/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)