diff mbox series

[FFmpeg-devel] avcodec/cbs_vp8: Remove empty flush callback

Message ID AS8P250MB074414545CD309D38A6B76828F522@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit 4d86e64d33afa76da9f052414c7fe5c1679fb5fa
Headers show
Series [FFmpeg-devel] avcodec/cbs_vp8: Remove empty flush callback | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Feb. 18, 2024, 7:39 p.m. UTC 
This callback is optional and should therefore only be set
if it actually does something.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/cbs_vp8.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Andreas Rheinhardt Feb. 19, 2024, 11:26 p.m. UTC | #1 
Andreas Rheinhardt:
> This callback is optional and should therefore only be set
> if it actually does something.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/cbs_vp8.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c
> index 065156c248..eabdef358f 100644
> --- a/libavcodec/cbs_vp8.c
> +++ b/libavcodec/cbs_vp8.c
> @@ -353,11 +353,6 @@ static int cbs_vp8_assemble_fragment(CodedBitstreamContext *ctx,
>      return AVERROR_PATCHWELCOME;
>  }
>  
> -static void cbs_vp8_flush(CodedBitstreamContext *ctx)
> -{
> -    // Do nothing.
> -}
> -
>  static const CodedBitstreamUnitTypeDescriptor cbs_vp8_unit_types[] = {
>      CBS_UNIT_TYPE_INTERNAL_REF(0, VP8RawFrame, data),
>      CBS_UNIT_TYPE_END_OF_LIST,
> @@ -374,7 +369,5 @@ const CodedBitstreamType ff_cbs_type_vp8 = {
>      .read_unit         = &cbs_vp8_read_unit,
>      .write_unit        = &cbs_vp8_write_unit,
>  
> -    .flush             = &cbs_vp8_flush,
> -
>      .assemble_fragment = &cbs_vp8_assemble_fragment,
>  };

Will apply this patch tomorrow unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c
index 065156c248..eabdef358f 100644
--- a/libavcodec/cbs_vp8.c
+++ b/libavcodec/cbs_vp8.c
@@ -353,11 +353,6 @@  static int cbs_vp8_assemble_fragment(CodedBitstreamContext *ctx,
     return AVERROR_PATCHWELCOME;
 }
 
-static void cbs_vp8_flush(CodedBitstreamContext *ctx)
-{
-    // Do nothing.
-}
-
 static const CodedBitstreamUnitTypeDescriptor cbs_vp8_unit_types[] = {
     CBS_UNIT_TYPE_INTERNAL_REF(0, VP8RawFrame, data),
     CBS_UNIT_TYPE_END_OF_LIST,
@@ -374,7 +369,5 @@  const CodedBitstreamType ff_cbs_type_vp8 = {
     .read_unit         = &cbs_vp8_read_unit,
     .write_unit        = &cbs_vp8_write_unit,
 
-    .flush             = &cbs_vp8_flush,
-
     .assemble_fragment = &cbs_vp8_assemble_fragment,
 };