diff mbox series

[FFmpeg-devel] avformat/matroskaenc: Fix potential stack-buffer-overflow

Message ID AS8P250MB07441F3393A1F9CD0D67CA248FDA2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
State New
Headers show
Series [FFmpeg-devel] avformat/matroskaenc: Fix potential stack-buffer-overflow | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt July 8, 2024, 5:09 p.m. UTC 
Forgotten in f194f291d8082134cdce625b0ca3548067428ea9

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavformat/matroskaenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Almer July 8, 2024, 5:54 p.m. UTC | #1 
On 7/8/2024 2:09 PM, Andreas Rheinhardt wrote:
> Forgotten in f194f291d8082134cdce625b0ca3548067428ea9
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   libavformat/matroskaenc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
> index 216cb48884..e1adc0eba6 100644
> --- a/libavformat/matroskaenc.c
> +++ b/libavformat/matroskaenc.c
> @@ -1758,7 +1758,7 @@ static int mkv_write_track_video(AVFormatContext *s, MatroskaMuxContext *mkv,
>       uint8_t color_space[4], projection_private[20];
>       const AVPacketSideData *sd;
>       EBML_WRITER(MAX_FIELD_ORDER_ELEMS + MAX_STEREO_MODE_ELEMS      +
> -                MAX_VIDEO_COLOR_ELEMS + MAX_VIDEO_PROJECTION_ELEMS + 8);
> +                MAX_VIDEO_COLOR_ELEMS + MAX_VIDEO_PROJECTION_ELEMS + 12);
>       int cropped_width = par->width, cropped_height = par->height;
>       int ret;
>   

LGTM, thanks.
diff mbox series

Patch

diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 216cb48884..e1adc0eba6 100644
--- a/libavformat/matroskaenc.c
+++ b/libavformat/matroskaenc.c
@@ -1758,7 +1758,7 @@  static int mkv_write_track_video(AVFormatContext *s, MatroskaMuxContext *mkv,
     uint8_t color_space[4], projection_private[20];
     const AVPacketSideData *sd;
     EBML_WRITER(MAX_FIELD_ORDER_ELEMS + MAX_STEREO_MODE_ELEMS      +
-                MAX_VIDEO_COLOR_ELEMS + MAX_VIDEO_PROJECTION_ELEMS + 8);
+                MAX_VIDEO_COLOR_ELEMS + MAX_VIDEO_PROJECTION_ELEMS + 12);
     int cropped_width = par->width, cropped_height = par->height;
     int ret;