diff mbox series

[FFmpeg-devel,2/2] avcodec/diracdec: Mark flush as av_cold

Message ID AS8P250MB07442CD87F23271D3A63DCAC8FF12@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit 8cbf7e8408465134f2cc5d8cdd1e41ab038ebb40
Headers show
Series [FFmpeg-devel,1/2] avcodec/diracdec: Use FF_CODEC_CAP_INIT_CLEANUP | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt May 28, 2024, 2:03 p.m. UTC 
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/diracdec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Lynne May 28, 2024, 2:22 p.m. UTC | #1 
On 28/05/2024 16:03, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   libavcodec/diracdec.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c
> index 5bf0dcc2db..76209aebba 100644
> --- a/libavcodec/diracdec.c
> +++ b/libavcodec/diracdec.c
> @@ -351,7 +351,7 @@ static int alloc_buffers(DiracContext *s, int stride)
>       return 0;
>   }
>   
> -static void free_sequence_buffers(DiracContext *s)
> +static av_cold void free_sequence_buffers(DiracContext *s)
>   {
>       int i, j, k;
>   
> @@ -413,7 +413,7 @@ static av_cold int dirac_decode_init(AVCodecContext *avctx)
>       return 0;
>   }
>   
> -static void dirac_decode_flush(AVCodecContext *avctx)
> +static av_cold void dirac_decode_flush(AVCodecContext *avctx)
>   {
>       DiracContext *s = avctx->priv_data;
>       free_sequence_buffers(s);

Both patches look good to me.
I'll remember to mark future decoders' flush with av_cold.
diff mbox series

Patch

diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c
index 5bf0dcc2db..76209aebba 100644
--- a/libavcodec/diracdec.c
+++ b/libavcodec/diracdec.c
@@ -351,7 +351,7 @@  static int alloc_buffers(DiracContext *s, int stride)
     return 0;
 }
 
-static void free_sequence_buffers(DiracContext *s)
+static av_cold void free_sequence_buffers(DiracContext *s)
 {
     int i, j, k;
 
@@ -413,7 +413,7 @@  static av_cold int dirac_decode_init(AVCodecContext *avctx)
     return 0;
 }
 
-static void dirac_decode_flush(AVCodecContext *avctx)
+static av_cold void dirac_decode_flush(AVCodecContext *avctx)
 {
     DiracContext *s = avctx->priv_data;
     free_sequence_buffers(s);