diff mbox series

[FFmpeg-devel,08/42] avcodec/dovi_rpu: Use RefStruct API for Vdr data

Message ID AS8P250MB0744359397C95961B29A23978FFAA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
State New
Headers show
Series New API for reference counting and ThreadFrames | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Sept. 19, 2023, 7:57 p.m. UTC 
It avoids allocations and the corresponding error checks.
Also avoids casts and indirections.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/dovi_rpu.c | 54 ++++++++++++++++++-------------------------
 libavcodec/dovi_rpu.h |  4 ++--
 libavcodec/hevcdec.c  |  4 +---
 3 files changed, 26 insertions(+), 36 deletions(-)

Comments

Anton Khirnov Oct. 2, 2023, 9:51 a.m. UTC | #1 
Quoting Andreas Rheinhardt (2023-09-19 21:57:00)
> It avoids allocations and the corresponding error checks.
> Also avoids casts and indirections.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/dovi_rpu.c | 54 ++++++++++++++++++-------------------------
>  libavcodec/dovi_rpu.h |  4 ++--
>  libavcodec/hevcdec.c  |  4 +---
>  3 files changed, 26 insertions(+), 36 deletions(-)
> 
> diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c
> index dd38936552..794fa878a7 100644
> --- a/libavcodec/dovi_rpu.c
> +++ b/libavcodec/dovi_rpu.c
> @@ -26,6 +26,7 @@
>  #include "dovi_rpu.h"
>  #include "golomb.h"
>  #include "get_bits.h"
> +#include "refstruct.h"
>  
>  enum {
>      RPU_COEFF_FIXED = 0,
> @@ -35,15 +36,15 @@ enum {
>  /**
>   * Private contents of vdr_ref.

Should update the comment as well.

Otherwise looks good.
diff mbox series

Patch

diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c
index dd38936552..794fa878a7 100644
--- a/libavcodec/dovi_rpu.c
+++ b/libavcodec/dovi_rpu.c
@@ -26,6 +26,7 @@ 
 #include "dovi_rpu.h"
 #include "golomb.h"
 #include "get_bits.h"
+#include "refstruct.h"
 
 enum {
     RPU_COEFF_FIXED = 0,
@@ -35,15 +36,15 @@  enum {
 /**
  * Private contents of vdr_ref.
  */
-typedef struct DOVIVdrRef {
+typedef struct DOVIVdr {
     AVDOVIDataMapping mapping;
     AVDOVIColorMetadata color;
-} DOVIVdrRef;
+} DOVIVdr;
 
 void ff_dovi_ctx_unref(DOVIContext *s)
 {
-    for (int i = 0; i < FF_ARRAY_ELEMS(s->vdr_ref); i++)
-        av_buffer_unref(&s->vdr_ref[i]);
+    for (int i = 0; i < FF_ARRAY_ELEMS(s->vdr); i++)
+        ff_refstruct_unref(&s->vdr[i]);
 
     *s = (DOVIContext) {
         .logctx = s->logctx,
@@ -52,8 +53,8 @@  void ff_dovi_ctx_unref(DOVIContext *s)
 
 void ff_dovi_ctx_flush(DOVIContext *s)
 {
-    for (int i = 0; i < FF_ARRAY_ELEMS(s->vdr_ref); i++)
-        av_buffer_unref(&s->vdr_ref[i]);
+    for (int i = 0; i < FF_ARRAY_ELEMS(s->vdr); i++)
+        ff_refstruct_unref(&s->vdr[i]);
 
     *s = (DOVIContext) {
         .logctx = s->logctx,
@@ -61,23 +62,14 @@  void ff_dovi_ctx_flush(DOVIContext *s)
     };
 }
 
-int ff_dovi_ctx_replace(DOVIContext *s, const DOVIContext *s0)
+void ff_dovi_ctx_replace(DOVIContext *s, const DOVIContext *s0)
 {
-    int ret;
     s->logctx = s0->logctx;
     s->mapping = s0->mapping;
     s->color = s0->color;
     s->dv_profile = s0->dv_profile;
-    for (int i = 0; i < DOVI_MAX_DM_ID; i++) {
-        if ((ret = av_buffer_replace(&s->vdr_ref[i], s0->vdr_ref[i])) < 0)
-            goto fail;
-    }
-
-    return 0;
-
-fail:
-    ff_dovi_ctx_unref(s);
-    return ret;
+    for (int i = 0; i < DOVI_MAX_DM_ID; i++)
+        ff_refstruct_replace(&s->vdr[i], s0->vdr[i]);
 }
 
 void ff_dovi_update_cfg(DOVIContext *s, const AVDOVIDecoderConfigurationRecord *cfg)
@@ -195,7 +187,7 @@  int ff_dovi_rpu_parse(DOVIContext *s, const uint8_t *rpu, size_t rpu_size)
 {
     AVDOVIRpuDataHeader *hdr = &s->header;
     GetBitContext *gb = &(GetBitContext){0};
-    DOVIVdrRef *vdr;
+    DOVIVdr *vdr;
     int ret;
 
     uint8_t nal_prefix;
@@ -278,23 +270,23 @@  int ff_dovi_rpu_parse(DOVIContext *s, const uint8_t *rpu, size_t rpu_size)
     if (use_prev_vdr_rpu) {
         int prev_vdr_rpu_id = get_ue_golomb_31(gb);
         VALIDATE(prev_vdr_rpu_id, 0, DOVI_MAX_DM_ID);
-        if (!s->vdr_ref[prev_vdr_rpu_id]) {
+        if (!s->vdr[prev_vdr_rpu_id]) {
             av_log(s->logctx, AV_LOG_ERROR, "Unknown previous RPU ID: %u\n",
                    prev_vdr_rpu_id);
             goto fail;
         }
-        vdr = (DOVIVdrRef *) s->vdr_ref[prev_vdr_rpu_id]->data;
+        vdr = s->vdr[prev_vdr_rpu_id];
         s->mapping = &vdr->mapping;
     } else {
         int vdr_rpu_id = get_ue_golomb_31(gb);
         VALIDATE(vdr_rpu_id, 0, DOVI_MAX_DM_ID);
-        if (!s->vdr_ref[vdr_rpu_id]) {
-            s->vdr_ref[vdr_rpu_id] = av_buffer_allocz(sizeof(DOVIVdrRef));
-            if (!s->vdr_ref[vdr_rpu_id])
+        if (!s->vdr[vdr_rpu_id]) {
+            s->vdr[vdr_rpu_id] = ff_refstruct_allocz(sizeof(DOVIVdr));
+            if (!s->vdr[vdr_rpu_id])
                 return AVERROR(ENOMEM);
         }
 
-        vdr = (DOVIVdrRef *) s->vdr_ref[vdr_rpu_id]->data;
+        vdr = s->vdr[vdr_rpu_id];
         s->mapping = &vdr->mapping;
 
         vdr->mapping.vdr_rpu_id = vdr_rpu_id;
@@ -390,24 +382,24 @@  int ff_dovi_rpu_parse(DOVIContext *s, const uint8_t *rpu, size_t rpu_size)
         int current_dm_id = get_ue_golomb_31(gb);
         VALIDATE(affected_dm_id, 0, DOVI_MAX_DM_ID);
         VALIDATE(current_dm_id, 0, DOVI_MAX_DM_ID);
-        if (!s->vdr_ref[affected_dm_id]) {
-            s->vdr_ref[affected_dm_id] = av_buffer_allocz(sizeof(DOVIVdrRef));
-            if (!s->vdr_ref[affected_dm_id])
+        if (!s->vdr[affected_dm_id]) {
+            s->vdr[affected_dm_id] = ff_refstruct_allocz(sizeof(DOVIVdr));
+            if (!s->vdr[affected_dm_id])
                 return AVERROR(ENOMEM);
         }
 
-        if (!s->vdr_ref[current_dm_id]) {
+        if (!s->vdr[current_dm_id]) {
             av_log(s->logctx, AV_LOG_ERROR, "Unknown previous RPU DM ID: %u\n",
                    current_dm_id);
             goto fail;
         }
 
         /* Update current pointer based on current_dm_id */
-        vdr = (DOVIVdrRef *) s->vdr_ref[current_dm_id]->data;
+        vdr = s->vdr[current_dm_id];
         s->color = &vdr->color;
 
         /* Update values of affected_dm_id */
-        vdr = (DOVIVdrRef *) s->vdr_ref[affected_dm_id]->data;
+        vdr = s->vdr[affected_dm_id];
         color = &vdr->color;
         color->dm_metadata_id = affected_dm_id;
         color->scene_refresh_flag = get_ue_golomb_31(gb);
diff --git a/libavcodec/dovi_rpu.h b/libavcodec/dovi_rpu.h
index f6ca5bbbc5..51c5fdbb87 100644
--- a/libavcodec/dovi_rpu.h
+++ b/libavcodec/dovi_rpu.h
@@ -47,12 +47,12 @@  typedef struct DOVIContext {
     /**
      * Private fields internal to dovi_rpu.c
      */
-    AVBufferRef *vdr_ref[DOVI_MAX_DM_ID+1];
+    struct DOVIVdr *vdr[DOVI_MAX_DM_ID+1]; ///< RefStruct references
     uint8_t dv_profile;
 
 } DOVIContext;
 
-int ff_dovi_ctx_replace(DOVIContext *s, const DOVIContext *s0);
+void ff_dovi_ctx_replace(DOVIContext *s, const DOVIContext *s0);
 
 /**
  * Completely reset a DOVIContext, preserving only logctx.
diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c
index d64055e1f9..44a9680415 100644
--- a/libavcodec/hevcdec.c
+++ b/libavcodec/hevcdec.c
@@ -3584,9 +3584,7 @@  static int hevc_update_thread_context(AVCodecContext *dst,
     if (ret < 0)
         return ret;
 
-    ret = ff_dovi_ctx_replace(&s->dovi_ctx, &s0->dovi_ctx);
-    if (ret < 0)
-        return ret;
+    ff_dovi_ctx_replace(&s->dovi_ctx, &s0->dovi_ctx);
 
     ret = av_buffer_replace(&s->sei.common.dynamic_hdr_vivid.info,
                             s0->sei.common.dynamic_hdr_vivid.info);