diff mbox series

[FFmpeg-devel] avcodec/libxeve: Use av_dict_iterate()

Message ID AS8P250MB07444695A89523734A83B5AF8F592@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit d36cb46681aa861b307e1fd378c543e1d84eb578
Headers show
Series [FFmpeg-devel] avcodec/libxeve: Use av_dict_iterate() | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Feb. 27, 2024, 8:36 p.m. UTC 
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/libxeve.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andreas Rheinhardt Feb. 29, 2024, 9:35 a.m. UTC | #1 
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/libxeve.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/libxeve.c b/libavcodec/libxeve.c
> index ef1681d397..c923ac1cac 100644
> --- a/libavcodec/libxeve.c
> +++ b/libavcodec/libxeve.c
> @@ -354,8 +354,8 @@ static av_cold int libxeve_init(AVCodecContext *avctx)
>      }
>  
>      {
> -        AVDictionaryEntry *en = NULL;
> -        while (en = av_dict_get(xectx->xeve_params, "", en, AV_DICT_IGNORE_SUFFIX)) {
> +        const AVDictionaryEntry *en = NULL;
> +        while (en = av_dict_iterate(xectx->xeve_params, en)) {
>              if ((ret = xeve_param_parse(&cdsc->param, en->key, en->value)) < 0) {
>                  av_log(avctx, AV_LOG_WARNING,
>                         "Error parsing option '%s = %s'.\n",

Will apply this patch tomorrow unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/libavcodec/libxeve.c b/libavcodec/libxeve.c
index ef1681d397..c923ac1cac 100644
--- a/libavcodec/libxeve.c
+++ b/libavcodec/libxeve.c
@@ -354,8 +354,8 @@  static av_cold int libxeve_init(AVCodecContext *avctx)
     }
 
     {
-        AVDictionaryEntry *en = NULL;
-        while (en = av_dict_get(xectx->xeve_params, "", en, AV_DICT_IGNORE_SUFFIX)) {
+        const AVDictionaryEntry *en = NULL;
+        while (en = av_dict_iterate(xectx->xeve_params, en)) {
             if ((ret = xeve_param_parse(&cdsc->param, en->key, en->value)) < 0) {
                 av_log(avctx, AV_LOG_WARNING,
                        "Error parsing option '%s = %s'.\n",