Message ID | AS8P250MB07444BD21A713CC047F130DC8F2C2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM |
---|---|
State | Accepted |
Commit | a7ad5d4d10ec5846fe2f96cec92dbce62ef185d8 |
Headers | show |
Series | [FFmpeg-devel,1/3] avformat/iamfenc: Remove always-false check | expand |
Context | Check | Description |
---|---|---|
yinshiyou/make_loongarch64 | success | Make finished |
yinshiyou/make_fate_loongarch64 | success | Make fate finished |
andriy/make_x86 | success | Make finished |
andriy/make_fate_x86 | success | Make fate finished |
On 3/19/2024 12:29 AM, Andreas Rheinhardt wrote: > This muxer does not have the AVFMT_NOSTREAMS flag; therefore > it is checked generically that there is at least a stream. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > --- > libavformat/iamfenc.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/libavformat/iamfenc.c b/libavformat/iamfenc.c > index ebf0c2fd67..bf4a268c95 100644 > --- a/libavformat/iamfenc.c > +++ b/libavformat/iamfenc.c > @@ -48,11 +48,6 @@ static int iamf_init(AVFormatContext *s) > int nb_audio_elements = 0, nb_mix_presentations = 0; > int ret; > > - if (!s->nb_streams) { > - av_log(s, AV_LOG_ERROR, "There must be at least one stream\n"); > - return AVERROR(EINVAL); > - } > - > for (int i = 0; i < s->nb_streams; i++) { > if (s->streams[i]->codecpar->codec_type != AVMEDIA_TYPE_AUDIO || > (s->streams[i]->codecpar->codec_tag != MKTAG('m','p','4','a') && Patchset LGTM.
diff --git a/libavformat/iamfenc.c b/libavformat/iamfenc.c index ebf0c2fd67..bf4a268c95 100644 --- a/libavformat/iamfenc.c +++ b/libavformat/iamfenc.c @@ -48,11 +48,6 @@ static int iamf_init(AVFormatContext *s) int nb_audio_elements = 0, nb_mix_presentations = 0; int ret; - if (!s->nb_streams) { - av_log(s, AV_LOG_ERROR, "There must be at least one stream\n"); - return AVERROR(EINVAL); - } - for (int i = 0; i < s->nb_streams; i++) { if (s->streams[i]->codecpar->codec_type != AVMEDIA_TYPE_AUDIO || (s->streams[i]->codecpar->codec_tag != MKTAG('m','p','4','a') &&
This muxer does not have the AVFMT_NOSTREAMS flag; therefore it is checked generically that there is at least a stream. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavformat/iamfenc.c | 5 ----- 1 file changed, 5 deletions(-)