diff mbox series

[FFmpeg-devel,1/7] avformat/iamf: Mark symbols as hidden

Message ID AS8P250MB07444EAF65D0588AB98CFC2F8F2A2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit 62412cd75d41ba497b0c7b2bac7f94d514c82115
Headers show
Series [FFmpeg-devel,1/7] avformat/iamf: Mark symbols as hidden | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt March 13, 2024, 11:07 p.m. UTC
Avoids .got entries for ff_iamf_scalable_ch_layouts and
ff_iamf_sound_system_map (whether they would have been
created otherwise depends upon the compiler and compiler
options).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavformat/iamf.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Andreas Rheinhardt March 16, 2024, 7:33 p.m. UTC | #1
Andreas Rheinhardt:
> Avoids .got entries for ff_iamf_scalable_ch_layouts and
> ff_iamf_sound_system_map (whether they would have been
> created otherwise depends upon the compiler and compiler
> options).
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavformat/iamf.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavformat/iamf.h b/libavformat/iamf.h
> index d662f6e76b..68f05c635b 100644
> --- a/libavformat/iamf.h
> +++ b/libavformat/iamf.h
> @@ -25,6 +25,7 @@
>  #include <stddef.h>
>  #include <stdint.h>
>  
> +#include "libavutil/attributes_internal.h"
>  #include "libavutil/channel_layout.h"
>  #include "libavutil/iamf.h"
>  #include "libavcodec/codec_id.h"
> @@ -162,6 +163,7 @@ struct IAMFSoundSystemMap {
>      AVChannelLayout layout;
>  };
>  
> +FF_VISIBILITY_PUSH_HIDDEN
>  extern const AVChannelLayout ff_iamf_scalable_ch_layouts[10];
>  extern const struct IAMFSoundSystemMap ff_iamf_sound_system_map[13];
>  
> @@ -195,5 +197,6 @@ static inline IAMFParamDefinition *ff_iamf_get_param_definition(const IAMFContex
>  void ff_iamf_free_audio_element(IAMFAudioElement **paudio_element);
>  void ff_iamf_free_mix_presentation(IAMFMixPresentation **pmix_presentation);
>  void ff_iamf_uninit_context(IAMFContext *c);
> +FF_VISIBILITY_POP_HIDDEN
>  
>  #endif /* AVFORMAT_IAMF_H */

Will apply this patchset tomorrow unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/libavformat/iamf.h b/libavformat/iamf.h
index d662f6e76b..68f05c635b 100644
--- a/libavformat/iamf.h
+++ b/libavformat/iamf.h
@@ -25,6 +25,7 @@ 
 #include <stddef.h>
 #include <stdint.h>
 
+#include "libavutil/attributes_internal.h"
 #include "libavutil/channel_layout.h"
 #include "libavutil/iamf.h"
 #include "libavcodec/codec_id.h"
@@ -162,6 +163,7 @@  struct IAMFSoundSystemMap {
     AVChannelLayout layout;
 };
 
+FF_VISIBILITY_PUSH_HIDDEN
 extern const AVChannelLayout ff_iamf_scalable_ch_layouts[10];
 extern const struct IAMFSoundSystemMap ff_iamf_sound_system_map[13];
 
@@ -195,5 +197,6 @@  static inline IAMFParamDefinition *ff_iamf_get_param_definition(const IAMFContex
 void ff_iamf_free_audio_element(IAMFAudioElement **paudio_element);
 void ff_iamf_free_mix_presentation(IAMFMixPresentation **pmix_presentation);
 void ff_iamf_uninit_context(IAMFContext *c);
+FF_VISIBILITY_POP_HIDDEN
 
 #endif /* AVFORMAT_IAMF_H */