diff mbox series

[FFmpeg-devel] tests/fate-run: Sanitize test argument

Message ID AS8P250MB074462B69AB74C4954ECCDDC8F452@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit 5e2b0862eb1d408625232b37b7a2420403cd498f
Headers show
Series [FFmpeg-devel] tests/fate-run: Sanitize test argument | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Feb. 7, 2024, 11:10 a.m. UTC 
test -z is a binary operator.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 tests/fate-run.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Andreas Rheinhardt Feb. 9, 2024, 9:55 a.m. UTC | #1 
Andreas Rheinhardt:
> test -z is a binary operator.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  tests/fate-run.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index 8efb1586b8..9257fb368b 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -243,7 +243,7 @@ enc_dec(){
>          -f $dec_fmt_out -y $tdecfile || return
>      do_md5sum $decfile
>      tests/tiny_psnr${HOSTEXECSUF} $srcfile $decfile $cmp_unit $cmp_shift
> -    test -z $ffprobe_opts || \
> +    test -z "$ffprobe_opts" || \
>          run ffprobe${PROGSUF}${EXECSUF} -bitexact $ffprobe_opts $tencfile || return
>  }
>  
> @@ -268,7 +268,7 @@ transcode(){
>      echo $(wc -c $encfile)
>      ffmpeg $DEC_OPTS $final_decode -i $tencfile $ENC_OPTS $FLAGS $final_encode \
>          -f framecrc - || return
> -    test -z $ffprobe_opts || \
> +    test -z "$ffprobe_opts" || \
>          run ffprobe${PROGSUF}${EXECSUF} -bitexact $ffprobe_opts $tencfile || return
>  }
>  
> @@ -288,7 +288,7 @@ stream_remux(){
>          -f $enc_fmt -y $tencfile || return
>      ffmpeg $DEC_OPTS -i $tencfile $ENC_OPTS $FLAGS $final_decode \
>          -f framecrc - || return
> -    test -z $ffprobe_opts || \
> +    test -z "$ffprobe_opts" || \
>          run ffprobe${PROGSUF}${EXECSUF} -bitexact $ffprobe_opts $tencfile || return
>  }
>  

Will apply this patch tomorrow unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/tests/fate-run.sh b/tests/fate-run.sh
index 8efb1586b8..9257fb368b 100755
--- a/tests/fate-run.sh
+++ b/tests/fate-run.sh
@@ -243,7 +243,7 @@  enc_dec(){
         -f $dec_fmt_out -y $tdecfile || return
     do_md5sum $decfile
     tests/tiny_psnr${HOSTEXECSUF} $srcfile $decfile $cmp_unit $cmp_shift
-    test -z $ffprobe_opts || \
+    test -z "$ffprobe_opts" || \
         run ffprobe${PROGSUF}${EXECSUF} -bitexact $ffprobe_opts $tencfile || return
 }
 
@@ -268,7 +268,7 @@  transcode(){
     echo $(wc -c $encfile)
     ffmpeg $DEC_OPTS $final_decode -i $tencfile $ENC_OPTS $FLAGS $final_encode \
         -f framecrc - || return
-    test -z $ffprobe_opts || \
+    test -z "$ffprobe_opts" || \
         run ffprobe${PROGSUF}${EXECSUF} -bitexact $ffprobe_opts $tencfile || return
 }
 
@@ -288,7 +288,7 @@  stream_remux(){
         -f $enc_fmt -y $tencfile || return
     ffmpeg $DEC_OPTS -i $tencfile $ENC_OPTS $FLAGS $final_decode \
         -f framecrc - || return
-    test -z $ffprobe_opts || \
+    test -z "$ffprobe_opts" || \
         run ffprobe${PROGSUF}${EXECSUF} -bitexact $ffprobe_opts $tencfile || return
 }