| Message ID | AS8P250MB0744763936DA411E5A4C088B8F292@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/3] fate/lavf-audio: Test writing AIFF-native tags | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | fail | Make fate failed |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | fail | Make fate failed |
On Thu, Mar 14, 2024 at 01:35:36AM +0100, Andreas Rheinhardt wrote: > In particular, test writing tags with odd strlen. > (These tags are zero-padded to even size.) > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > --- > tests/fate/lavf-audio.mak | 1 + > tests/ref/lavf/aiff | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) needs to update seek test too: --- ./tests/ref/seek/lavf-aiff 2024-03-05 02:37:36.243300240 +0100 +++ tests/data/fate/seek-lavf-aiff 2024-03-14 22:24:47.357654173 +0100 @@ -1,53 +1,53 @@ -ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 70 size: 4096 +ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 84 size: 4096 ret: 0 st:-1 flags:0 ts:-1.000000 -ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 70 size: 4096 +ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 84 size: 4096 ret: 0 st:-1 flags:1 ts: 1.894167 ret:-EOF ret: 0 st: 0 flags:0 ts: 0.788345 -ret: 0 st: 0 flags:1 dts: 0.788345 pts: 0.788345 pos: 69602 size: 4096 +ret: 0 st: 0 flags:1 dts: 0.788345 pts: 0.788345 pos: 69616 size: 4096 ret: 0 st: 0 flags:1 ts:-0.317506 -ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 70 size: 4096 +ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 84 size: 4096 ... thx [...]
Michael Niedermayer: > On Thu, Mar 14, 2024 at 01:35:36AM +0100, Andreas Rheinhardt wrote: >> In particular, test writing tags with odd strlen. >> (These tags are zero-padded to even size.) >> >> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> >> --- >> tests/fate/lavf-audio.mak | 1 + >> tests/ref/lavf/aiff | 4 ++-- >> 2 files changed, 3 insertions(+), 2 deletions(-) > > needs to update seek test too: > Yeah, I already did it locally. Sorry for this. - Andreas
Andreas Rheinhardt: > In particular, test writing tags with odd strlen. > (These tags are zero-padded to even size.) > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > --- > tests/fate/lavf-audio.mak | 1 + > tests/ref/lavf/aiff | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/fate/lavf-audio.mak b/tests/fate/lavf-audio.mak > index d54cd107e0..7ea0c41da9 100644 > --- a/tests/fate/lavf-audio.mak > +++ b/tests/fate/lavf-audio.mak > @@ -28,6 +28,7 @@ $(FATE_LAVF_AUDIO): CMD = lavf_audio > $(FATE_LAVF_AUDIO): REF = $(SRC_PATH)/tests/ref/lavf/$(@:fate-lavf-%=%) > $(FATE_LAVF_AUDIO): $(AREF) > > +fate-lavf-aiff: CMD = lavf_audio "" "-metadata copyright=noone" > fate-lavf-al fate-lavf-ul: CMD = lavf_audio "" "" "-ar 44100" > fate-lavf-dfpwm: CMD = lavf_audio "" "" "-sample_rate 44100" > fate-lavf-ogg: CMD = lavf_audio "" "-c:a flac" > diff --git a/tests/ref/lavf/aiff b/tests/ref/lavf/aiff > index d72ec85150..e208ff3e16 100644 > --- a/tests/ref/lavf/aiff > +++ b/tests/ref/lavf/aiff > @@ -1,3 +1,3 @@ > -2c129d88acef834e32869145fe792b9c *tests/data/lavf/lavf.aiff > -88270 tests/data/lavf/lavf.aiff > +655b5bd68e7a59599ab6663de0015324 *tests/data/lavf/lavf.aiff > +88284 tests/data/lavf/lavf.aiff > tests/data/lavf/lavf.aiff CRC=0x3a1da17e Will apply this patchset with the fate references updated. - Andreas
diff --git a/tests/fate/lavf-audio.mak b/tests/fate/lavf-audio.mak index d54cd107e0..7ea0c41da9 100644 --- a/tests/fate/lavf-audio.mak +++ b/tests/fate/lavf-audio.mak @@ -28,6 +28,7 @@ $(FATE_LAVF_AUDIO): CMD = lavf_audio $(FATE_LAVF_AUDIO): REF = $(SRC_PATH)/tests/ref/lavf/$(@:fate-lavf-%=%) $(FATE_LAVF_AUDIO): $(AREF) +fate-lavf-aiff: CMD = lavf_audio "" "-metadata copyright=noone" fate-lavf-al fate-lavf-ul: CMD = lavf_audio "" "" "-ar 44100" fate-lavf-dfpwm: CMD = lavf_audio "" "" "-sample_rate 44100" fate-lavf-ogg: CMD = lavf_audio "" "-c:a flac" diff --git a/tests/ref/lavf/aiff b/tests/ref/lavf/aiff index d72ec85150..e208ff3e16 100644 --- a/tests/ref/lavf/aiff +++ b/tests/ref/lavf/aiff @@ -1,3 +1,3 @@ -2c129d88acef834e32869145fe792b9c *tests/data/lavf/lavf.aiff -88270 tests/data/lavf/lavf.aiff +655b5bd68e7a59599ab6663de0015324 *tests/data/lavf/lavf.aiff +88284 tests/data/lavf/lavf.aiff tests/data/lavf/lavf.aiff CRC=0x3a1da17e
In particular, test writing tags with odd strlen. (These tags are zero-padded to even size.) Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- tests/fate/lavf-audio.mak | 1 + tests/ref/lavf/aiff | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)