diff mbox series

[FFmpeg-devel,1/9] avcodec/libxevd: Remove FF_CODEC_CAP_SETS_PKT_DTS cap

Message ID AS8P250MB0744C151DFBF003F282F0AAD8F592@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
State New
Headers show
Series [FFmpeg-devel,1/9] avcodec/libxevd: Remove FF_CODEC_CAP_SETS_PKT_DTS cap | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Feb. 27, 2024, 7:48 p.m. UTC
This decoder implements the receive_frame API; such decoders
always have to set the pkt_dts field themselves and the avcodec
test checks for this.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/libxevd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Rheinhardt Feb. 29, 2024, 9:36 a.m. UTC | #1
Andreas Rheinhardt:
> This decoder implements the receive_frame API; such decoders
> always have to set the pkt_dts field themselves and the avcodec
> test checks for this.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/libxevd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
> index 58ef90d929..eb007e30fe 100644
> --- a/libavcodec/libxevd.c
> +++ b/libavcodec/libxevd.c
> @@ -534,5 +534,5 @@ const FFCodec ff_libxevd_decoder = {
>      .p.capabilities     = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_OTHER_THREADS | AV_CODEC_CAP_AVOID_PROBING,
>      .p.profiles         = NULL_IF_CONFIG_SMALL(ff_evc_profiles),
>      .p.wrapper_name     = "libxevd",
> -    .caps_internal      = FF_CODEC_CAP_INIT_CLEANUP | FF_CODEC_CAP_NOT_INIT_THREADSAFE | FF_CODEC_CAP_SETS_PKT_DTS | FF_CODEC_CAP_SETS_FRAME_PROPS
> +    .caps_internal      = FF_CODEC_CAP_INIT_CLEANUP | FF_CODEC_CAP_NOT_INIT_THREADSAFE | FF_CODEC_CAP_SETS_FRAME_PROPS
>  };

Will apply this patchset tomorrow unless there are objections.

- Andreas
Dawid Kozinski March 6, 2024, 10:37 a.m. UTC | #2
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: wtorek, 27 lutego 2024 20:48
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> Subject: [FFmpeg-devel] [PATCH 1/9] avcodec/libxevd: Remove
> FF_CODEC_CAP_SETS_PKT_DTS cap
> 
> This decoder implements the receive_frame API; such decoders always have
to
> set the pkt_dts field themselves and the avcodec test checks for this.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/libxevd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c index
> 58ef90d929..eb007e30fe 100644
> --- a/libavcodec/libxevd.c
> +++ b/libavcodec/libxevd.c
> @@ -534,5 +534,5 @@ const FFCodec ff_libxevd_decoder = {
>      .p.capabilities     = AV_CODEC_CAP_DELAY |
> AV_CODEC_CAP_OTHER_THREADS | AV_CODEC_CAP_AVOID_PROBING,
>      .p.profiles         = NULL_IF_CONFIG_SMALL(ff_evc_profiles),
>      .p.wrapper_name     = "libxevd",
> -    .caps_internal      = FF_CODEC_CAP_INIT_CLEANUP |
> FF_CODEC_CAP_NOT_INIT_THREADSAFE | FF_CODEC_CAP_SETS_PKT_DTS |
> FF_CODEC_CAP_SETS_FRAME_PROPS
> +    .caps_internal      = FF_CODEC_CAP_INIT_CLEANUP |
> FF_CODEC_CAP_NOT_INIT_THREADSAFE |
> FF_CODEC_CAP_SETS_FRAME_PROPS
>  };
> --
> 2.40.1
> 
It has been checked. Looks good.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://protect2.fireeye.com/v1/url?k=90421711-f13fff56-90439c5e-
> 74fe485fff30-8ac153898cae4df3&q=1&e=8fc861d3-bd49-4b68-a822-
> 7514fe931b97&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp
> eg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
Dawid Kozinski March 6, 2024, 10:38 a.m. UTC | #3
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: czwartek, 29 lutego 2024 10:37
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 1/9] avcodec/libxevd: Remove
> FF_CODEC_CAP_SETS_PKT_DTS cap
> 
> Andreas Rheinhardt:
> > This decoder implements the receive_frame API; such decoders always
> > have to set the pkt_dts field themselves and the avcodec test checks
> > for this.
> >
> > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> > ---
> >  libavcodec/libxevd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c index
> > 58ef90d929..eb007e30fe 100644
> > --- a/libavcodec/libxevd.c
> > +++ b/libavcodec/libxevd.c
> > @@ -534,5 +534,5 @@ const FFCodec ff_libxevd_decoder = {
> >      .p.capabilities     = AV_CODEC_CAP_DELAY |
> AV_CODEC_CAP_OTHER_THREADS | AV_CODEC_CAP_AVOID_PROBING,
> >      .p.profiles         = NULL_IF_CONFIG_SMALL(ff_evc_profiles),
> >      .p.wrapper_name     = "libxevd",
> > -    .caps_internal      = FF_CODEC_CAP_INIT_CLEANUP |
> FF_CODEC_CAP_NOT_INIT_THREADSAFE | FF_CODEC_CAP_SETS_PKT_DTS |
> FF_CODEC_CAP_SETS_FRAME_PROPS
> > +    .caps_internal      = FF_CODEC_CAP_INIT_CLEANUP |
> FF_CODEC_CAP_NOT_INIT_THREADSAFE |
> FF_CODEC_CAP_SETS_FRAME_PROPS
> >  };
> 
> Will apply this patchset tomorrow unless there are objections.
> 
No objections. It has been checked. Looks good.

> - Andreas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://protect2.fireeye.com/v1/url?k=2ba11787-4adabd0f-2ba09cc8-
> 74fe4860018a-c9fa419a18ec0235&q=1&e=1f7f95c0-bdda-4754-9900-
> 6c849de896ad&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp
> eg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
index 58ef90d929..eb007e30fe 100644
--- a/libavcodec/libxevd.c
+++ b/libavcodec/libxevd.c
@@ -534,5 +534,5 @@  const FFCodec ff_libxevd_decoder = {
     .p.capabilities     = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_OTHER_THREADS | AV_CODEC_CAP_AVOID_PROBING,
     .p.profiles         = NULL_IF_CONFIG_SMALL(ff_evc_profiles),
     .p.wrapper_name     = "libxevd",
-    .caps_internal      = FF_CODEC_CAP_INIT_CLEANUP | FF_CODEC_CAP_NOT_INIT_THREADSAFE | FF_CODEC_CAP_SETS_PKT_DTS | FF_CODEC_CAP_SETS_FRAME_PROPS
+    .caps_internal      = FF_CODEC_CAP_INIT_CLEANUP | FF_CODEC_CAP_NOT_INIT_THREADSAFE | FF_CODEC_CAP_SETS_FRAME_PROPS
 };