| Message ID | AS8P250MB0744EDB71F6BFA7D3FF3B3C58F5A9@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM |
|---|---|
| State | Withdrawn |
| Headers | show |
| Series | [FFmpeg-devel,1/9] avutil/attributes_internal: Add visibility pragma | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
Oct 4, 2022, 13:09 by andreas.rheinhardt@outlook.com: > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > --- > libavcodec/opus.h | 2 +- > libavcodec/opus_celt.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/opus.h b/libavcodec/opus.h > index 80d685d47c..4d061cf5f8 100644 > --- a/libavcodec/opus.h > +++ b/libavcodec/opus.h > @@ -1,5 +1,5 @@ > /* > - * Opus decoder/demuxer common functions > + * Opus common header > * Copyright (c) 2012 Andrew D'Addesio > * Copyright (c) 2013-2014 Mozilla Corporation > * > diff --git a/libavcodec/opus_celt.h b/libavcodec/opus_celt.h > index 3aa96244e1..2dbb79be6c 100644 > --- a/libavcodec/opus_celt.h > +++ b/libavcodec/opus_celt.h > @@ -1,5 +1,5 @@ > /* > - * Opus decoder/demuxer common functions > + * Opus decoder/encoder CELT functions > * Copyright (c) 2012 Andrew D'Addesio > * Copyright (c) 2013-2014 Mozilla Corporation > * Copyright (c) 2016 Rostislav Pehlivanov <> atomnuker@gmail.com> > > Could you merge this with patch 7/9? Patchset looks good to me (as well as your more recent patch for the visibility pragma).
Lynne: > Oct 4, 2022, 13:09 by andreas.rheinhardt@outlook.com: > >> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> >> --- >> libavcodec/opus.h | 2 +- >> libavcodec/opus_celt.h | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/opus.h b/libavcodec/opus.h >> index 80d685d47c..4d061cf5f8 100644 >> --- a/libavcodec/opus.h >> +++ b/libavcodec/opus.h >> @@ -1,5 +1,5 @@ >> /* >> - * Opus decoder/demuxer common functions >> + * Opus common header >> * Copyright (c) 2012 Andrew D'Addesio >> * Copyright (c) 2013-2014 Mozilla Corporation >> * >> diff --git a/libavcodec/opus_celt.h b/libavcodec/opus_celt.h >> index 3aa96244e1..2dbb79be6c 100644 >> --- a/libavcodec/opus_celt.h >> +++ b/libavcodec/opus_celt.h >> @@ -1,5 +1,5 @@ >> /* >> - * Opus decoder/demuxer common functions >> + * Opus decoder/encoder CELT functions >> * Copyright (c) 2012 Andrew D'Addesio >> * Copyright (c) 2013-2014 Mozilla Corporation >> * Copyright (c) 2016 Rostislav Pehlivanov <> atomnuker@gmail.com> > >> > > Could you merge this with patch 7/9? > > Patchset looks good to me (as well as your more recent patch > for the visibility pragma). Will merge the opus.h change into 4/9 and the opus_celt.h patch into 7/9 and apply 3-9; but I will wait with the visibility patch a bit more to give others more time to comment. - Andreas
diff --git a/libavcodec/opus.h b/libavcodec/opus.h index 80d685d47c..4d061cf5f8 100644 --- a/libavcodec/opus.h +++ b/libavcodec/opus.h @@ -1,5 +1,5 @@ /* - * Opus decoder/demuxer common functions + * Opus common header * Copyright (c) 2012 Andrew D'Addesio * Copyright (c) 2013-2014 Mozilla Corporation * diff --git a/libavcodec/opus_celt.h b/libavcodec/opus_celt.h index 3aa96244e1..2dbb79be6c 100644 --- a/libavcodec/opus_celt.h +++ b/libavcodec/opus_celt.h @@ -1,5 +1,5 @@ /* - * Opus decoder/demuxer common functions + * Opus decoder/encoder CELT functions * Copyright (c) 2012 Andrew D'Addesio * Copyright (c) 2013-2014 Mozilla Corporation * Copyright (c) 2016 Rostislav Pehlivanov <atomnuker@gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavcodec/opus.h | 2 +- libavcodec/opus_celt.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)