diff mbox series

[FFmpeg-devel,2/2] tests/fate-run: Don't create unnecessary CRC-files, forward errors

Message ID AS8PR01MB7944BC413B6B5D1E1EF656208FC09@AS8PR01MB7944.eurprd01.prod.exchangelabs.com
State Accepted
Commit bf1337f99c66ac574c6e4da65c305ca878f1d65d
Headers show
Series [FFmpeg-devel,1/2] fate/lavf-audio: Disable CRC for lavf-peak_only.wav test | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt May 3, 2022, 3:27 a.m. UTC 
These CRC-only files (the output of the CRC-muxer) are only used once,
so they need not be preserved. Furthermore, errors from ffmpeg (used
for creating the CRC) are no longer ignored with this patch.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 tests/fate-run.sh | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/tests/fate-run.sh b/tests/fate-run.sh
index c206a439b2..4f8988b964 100755
--- a/tests/fate-run.sh
+++ b/tests/fate-run.sh
@@ -272,8 +272,6 @@  stream_remux(){
 ffmpeg2="$target_exec ${target_path}/ffmpeg${PROGSUF}${EXECSUF}"
 raw_src="${target_path}/tests/vsynth1/%02d.pgm"
 pcm_src="${target_path}/tests/data/asynth1.sw"
-crcfile="tests/data/$test.lavf.crc"
-target_crcfile="${target_path}/$crcfile"
 
 [ "${V-0}" -gt 0 ] && echov=echov || echov=:
 
@@ -303,8 +301,8 @@  do_avconv(){
 do_avconv_crc(){
     f="$1"
     shift
-    run_avconv $* -f crc "$target_crcfile"
-    echo "$f $(cat $crcfile)"
+    printf "%s " "$f"
+    run_avconv $* -f crc -
 }
 
 lavf_audio(){