| Message ID | BLAPR07MB7668DB905A39FAF7238CAC85CC002@BLAPR07MB7668.namprd07.prod.outlook.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] avutil/hwcontext_d3d12va: wait the texture is used before to free it. | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/configure_loongarch64 | warning | Failed to apply patch |
| andriy/configure_x86 | warning | Failed to apply patch |
Hi, >From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Renan >Lavarec via ffmpeg-devel >Sent: Monday, April 8, 2024 11:27 PM >To: ffmpeg-devel@ffmpeg.org >Cc: Renan Lavarec <rlavarec@gopro.com> >Subject: [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d12va: wait the texture is >used before to free it. > >From: Renan Lavarec 124602499+rlavarec- >gpsw@users.noreply.github.com<mailto:124602499+rlavarec- >gpsw@users.noreply.github.com> >Date: Mon, 8 Apr 2024 14:38:10 +0200 >Subject: [PATCH] avutil/hwcontext_d3d12va: wait the texture is used inside the >GPU before to free it. > >fix: ID3D12Resource2::<final-release>: CORRUPTION: An ID3D12Resource >object (0x00000222D58B5450:'Unnamed Object') is referenced by GPU >operations in-flight on Command Queue (0x00000222EEC87090:'Unnamed >ID3D12CommandQueue Object'). > It is not safe to final-release objects that may have GPU operations pending. >This can result in application instability. [ EXECUTION ERROR #921: >OBJECT_DELETED_WHILE_STILL_IN_USE] >--- >libavutil/hwcontext_d3d12va.c | 3 +++ >1 file changed, 3 insertions(+) > >diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c >index cfc016315d..621a79d257 100644 >--- a/libavutil/hwcontext_d3d12va.c >+++ b/libavutil/hwcontext_d3d12va.c >@@ -220,6 +220,9 @@ static void free_texture(void *opaque, uint8_t *data) >{ > AVD3D12VAFrame *frame = (AVD3D12VAFrame *)data; > >+ // Wait texture to be available >+ d3d12va_fence_completion(&frame->sync_ctx); >+ > D3D12_OBJECT_RELEASE(frame->texture); > D3D12_OBJECT_RELEASE(frame->sync_ctx.fence); > if (frame->sync_ctx.event) >-- >2.44.0.windows.1 At what scenario will this happen? I think decoder should be responsible for the completion of the CommandQueue before releasing the buffer pool. And that's what d3d12va_decode has already done in uninit call. Thanks. -Tong
diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c index cfc016315d..621a79d257 100644 --- a/libavutil/hwcontext_d3d12va.c +++ b/libavutil/hwcontext_d3d12va.c @@ -220,6 +220,9 @@ static void free_texture(void *opaque, uint8_t *data) { AVD3D12VAFrame *frame = (AVD3D12VAFrame *)data; + // Wait texture to be available + d3d12va_fence_completion(&frame->sync_ctx); + D3D12_OBJECT_RELEASE(frame->texture); D3D12_OBJECT_RELEASE(frame->sync_ctx.fence); if (frame->sync_ctx.event)
From: Renan Lavarec 124602499+rlavarec-gpsw@users.noreply.github.com<mailto:124602499+rlavarec-gpsw@users.noreply.github.com> Date: Mon, 8 Apr 2024 14:38:10 +0200 Subject: [PATCH] avutil/hwcontext_d3d12va: wait the texture is used inside the GPU before to free it. fix: ID3D12Resource2::<final-release>: CORRUPTION: An ID3D12Resource object (0x00000222D58B5450:'Unnamed Object') is referenced by GPU operations in-flight on Command Queue (0x00000222EEC87090:'Unnamed ID3D12CommandQueue Object'). It is not safe to final-release objects that may have GPU operations pending. This can result in application instability. [ EXECUTION ERROR #921: OBJECT_DELETED_WHILE_STILL_IN_USE] --- libavutil/hwcontext_d3d12va.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.44.0.windows.1