diff mbox

[FFmpeg-devel] lavf/mxfenc: Support 60fps output

Message ID CAB0OVGoNJu6xCV4hUiwyy2fWC46RwcGOEbEWdRzuXMFO6xV4uw@mail.gmail.com
State Accepted
Headers show

Commit Message

Carl Eugen Hoyos Oct. 30, 2017, 11:22 p.m. UTC
Hi!

Kasper Folman has reported that FFmpeg does not write 60fps mxf output
and has provided a 60fps mxf file on -users.

Attached patch allows 60fps output.

Please comment, Carl Eugen

Comments

Carl Eugen Hoyos Nov. 16, 2017, 1:27 p.m. UTC | #1
2017-10-31 0:22 GMT+01:00 Carl Eugen Hoyos <ceffmpeg@gmail.com>:
> Hi!
>
> Kasper Folman has reported that FFmpeg does not write 60fps
> mxf output and has provided a 60fps mxf file on -users.
>
> Attached patch allows 60fps output.

This was successfully tested so I will push if there are no objections.

Carl Eugen
Derek Buitenhuis Nov. 16, 2017, 2:08 p.m. UTC | #2
On 11/16/2017 1:27 PM, Carl Eugen Hoyos wrote:
> This was successfully tested so I will push if there are no objections.

Seems harmless enough if it isn't violating some spec (it is MXF after all...)

If someone had objections, they would have responded by now, probably.

- Derek
Carl Eugen Hoyos Nov. 16, 2017, 10:48 p.m. UTC | #3
2017-11-16 15:08 GMT+01:00 Derek Buitenhuis <derek.buitenhuis@gmail.com>:
> On 11/16/2017 1:27 PM, Carl Eugen Hoyos wrote:
>> This was successfully tested so I will push if there are no objections.
>
> Seems harmless enough if it isn't violating some spec (it is MXF after all...)
>
> If someone had objections, they would have responded by now, probably.

Patch applied.

Carl Eugen
diff mbox

Patch

From bb5b071db9a8977bd1a7dea579b4d244e17ca3a3 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Tue, 31 Oct 2017 00:19:38 +0100
Subject: [PATCH] lavf/mxfenc: Support 60fps output.

---
 libavformat/mxf.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/mxf.c b/libavformat/mxf.c
index bfc3218..5994b09 100644
--- a/libavformat/mxf.c
+++ b/libavformat/mxf.c
@@ -137,6 +137,7 @@  static const MXFSamplesPerFrame mxf_spf[] = {
     { { 1001, 60000 }, { 801,  801,  801,  801,  800,  0 } }, // NTSC 59.94
     { { 1, 25 },       { 1920, 0,    0,    0,    0,    0 } }, // PAL 25
     { { 1, 50 },       { 960,  0,    0,    0,    0,    0 } }, // PAL 50
+    { { 1, 60 },       { 800,  0,    0,    0,    0,    0 } },
 };
 
 static const AVRational mxf_time_base[] = {
@@ -146,6 +147,7 @@  static const AVRational mxf_time_base[] = {
     { 1001, 60000 },
     { 1, 25 },
     { 1, 50 },
+    { 1, 60 },
     { 0, 0}
 };
 
-- 
1.7.10.4