| Message ID | CAEa-L+vamksy3_ndECce4Fv=cBC11doiL=vaTCDXKfSOXazWRg@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/6] checkasm/takdsp: add decorrelate_ls test | expand |
| Context | Check | Description |
|---|---|---|
| andriy/configure_x86 | warning | Failed to apply patch |
| yinshiyou/configure_loongarch64 | warning | Failed to apply patch |
On Mon, 18 Dec 2023, flow gg wrote: > > +static void test_decorrelate_sm(TAKDSPContext *s) { > +#define BUF_SIZE 1024 > + declare_func(void, int32_t *, int32_t *, int); > + > + if (check_func(s->decorrelate_sm, "decorrelate_sm")) { > + LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]); > + LOCAL_ALIGNED_32(int32_t, p1_2, [BUF_SIZE]); > + LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]); > + LOCAL_ALIGNED_32(int32_t, p2_2, [BUF_SIZE]); > + > + randomize(p1, BUF_SIZE); > + memcpy(p1, p1_2, BUF_SIZE); p1 is the one that is filled with initialized data here, not the other way around. Clang optimizes out this memcpy since it's copying uninitialized data. > + randomize(p2, BUF_SIZE); > + memcpy(p2_2, p2, BUF_SIZE); > + > + call_ref(p1, p2, BUF_SIZE); > + call_new(p1_2, p2_2, BUF_SIZE); > + > + if (memcmp(p2, p2_2, BUF_SIZE) != 0){ As this function mutates both p1 and p2, we need to check both of them. Also *sizeof(). // Martin
From 9e09f52403058e1bc87653bfd9980c7d5a6ce33c Mon Sep 17 00:00:00 2001 From: sunyuechi <sunyuechi@iscas.ac.cn> Date: Mon, 18 Dec 2023 22:48:09 +0800 Subject: [PATCH 3/6] checkasm/takdsp: add decorrelate_sm test --- tests/checkasm/takdsp.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/tests/checkasm/takdsp.c b/tests/checkasm/takdsp.c index 2fa639bfc1..495b7242c5 100644 --- a/tests/checkasm/takdsp.c +++ b/tests/checkasm/takdsp.c @@ -85,6 +85,34 @@ static void test_decorrelate_sr(TAKDSPContext *s) { report("decorrelate_sr"); } +static void test_decorrelate_sm(TAKDSPContext *s) { +#define BUF_SIZE 1024 + declare_func(void, int32_t *, int32_t *, int); + + if (check_func(s->decorrelate_sm, "decorrelate_sm")) { + LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]); + LOCAL_ALIGNED_32(int32_t, p1_2, [BUF_SIZE]); + LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]); + LOCAL_ALIGNED_32(int32_t, p2_2, [BUF_SIZE]); + + randomize(p1, BUF_SIZE); + memcpy(p1, p1_2, BUF_SIZE); + randomize(p2, BUF_SIZE); + memcpy(p2_2, p2, BUF_SIZE); + + call_ref(p1, p2, BUF_SIZE); + call_new(p1_2, p2_2, BUF_SIZE); + + if (memcmp(p2, p2_2, BUF_SIZE) != 0){ + fail(); + } + + bench_new(p1, p2, BUF_SIZE); + } + + report("decorrelate_sm"); +} + void checkasm_check_takdsp(void) { TAKDSPContext s = { 0 }; @@ -92,4 +120,5 @@ void checkasm_check_takdsp(void) test_decorrelate_ls(&s); test_decorrelate_sr(&s); + test_decorrelate_sm(&s); } -- 2.43.0