diff mbox series

[FFmpeg-devel] avcodec/aacdec_usac: Fix array size

Message ID D2FDDF9K3LKG.1UMGFPDDTTUWC@gmail.com
State New
Headers show
Series [FFmpeg-devel] avcodec/aacdec_usac: Fix array size | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Marvin Scholz July 2, 2024, 9:25 p.m. UTC 
The array in ff_aac_usac_mdst_filt_cur that is passed to that has a size
of 7 elements, not 6 and the code in the function accesses the array at
index 6, which would be out of bounds if the size was actually 6.

Fixes: CID1603196
---
 libavcodec/aac/aacdec_usac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: e783e45e29e78616debba7f6d1fe6e54dc336496

Comments

Lynne July 3, 2024, 12:49 a.m. UTC | #1 
On 02/07/2024 23:25, Marvin Scholz wrote:
> The array in ff_aac_usac_mdst_filt_cur that is passed to that has a size
> of 7 elements, not 6 and the code in the function accesses the array at
> index 6, which would be out of bounds if the size was actually 6.
> 
> Fixes: CID1603196
> ---
>   libavcodec/aac/aacdec_usac.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
> index 4856c1786b..32b3c534bf 100644
> --- a/libavcodec/aac/aacdec_usac.c
> +++ b/libavcodec/aac/aacdec_usac.c
> @@ -1134,7 +1134,7 @@ static void complex_stereo_downmix_cur(AACDecContext *ac, ChannelElement *cpe,
>       }
>   }
>   
> -static void complex_stereo_interpolate_imag(float *im, float *re, const float f[6],
> +static void complex_stereo_interpolate_imag(float *im, float *re, const float f[7],
>                                               int len, int factor_even, int factor_odd)
>   {
>       int i = 0;
> 
> base-commit: e783e45e29e78616debba7f6d1fe6e54dc336496

Thanks, pushed
diff mbox series

Patch

diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
index 4856c1786b..32b3c534bf 100644
--- a/libavcodec/aac/aacdec_usac.c
+++ b/libavcodec/aac/aacdec_usac.c
@@ -1134,7 +1134,7 @@  static void complex_stereo_downmix_cur(AACDecContext *ac, ChannelElement *cpe,
     }
 }
 
-static void complex_stereo_interpolate_imag(float *im, float *re, const float f[6],
+static void complex_stereo_interpolate_imag(float *im, float *re, const float f[7],
                                             int len, int factor_even, int factor_odd)
 {
     int i = 0;