diff mbox series

[FFmpeg-devel,04/60] lavfi/vf_ssim360: use av_err2str to simplify code

Message ID D41CE2FHVAS8.300OVAZA5XCVN@gmail.com
State Accepted
Headers show
Series [FFmpeg-devel,01/60] fftools/ffmpeg_opt: fix variable shadowing | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Marvin Scholz Sept. 8, 2024, 5:50 p.m. UTC 
No need to explicitly specify the buffer here as it is only ever passed
to av_log, so av_err2str can be used.
---
 libavfilter/vf_ssim360.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Anton Khirnov Sept. 9, 2024, 10:12 a.m. UTC | #1 
Quoting Marvin Scholz (2024-09-08 19:50:46)
> No need to explicitly specify the buffer here as it is only ever passed
> to av_log, so av_err2str can be used.
> ---
>  libavfilter/vf_ssim360.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Looks ok.
diff mbox series

Patch

diff --git a/libavfilter/vf_ssim360.c b/libavfilter/vf_ssim360.c
index 57da2f3938..68bd7b4d78 100644
--- a/libavfilter/vf_ssim360.c
+++ b/libavfilter/vf_ssim360.c
@@ -1320,12 +1320,9 @@  static av_cold int init(AVFilterContext *ctx)
         } else {
             s->stats_file = avpriv_fopen_utf8(s->stats_file_str, "w");
             if (!s->stats_file) {
-                char buf[128];
-
                 err = AVERROR(errno);
-                av_strerror(err, buf, sizeof(buf));
                 av_log(ctx, AV_LOG_ERROR, "Could not open stats file %s: %s\n",
-                       s->stats_file_str, buf);
+                       s->stats_file_str, av_err2str(err));
                 return err;
             }
         }