diff mbox series

[FFmpeg-devel,1/2] avcodec/wrapped_avframe: Don't attach FrameDecodeData unnecessarily

Message ID DB6PR0101MB2214219ED88C3F7D113055BF8FC89@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com
State Accepted
Commit d31a3af6a994c4afaa39d6f781ddbdd519d417f8
Headers show
Series [FFmpeg-devel,1/2] avcodec/wrapped_avframe: Don't attach FrameDecodeData unnecessarily | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt May 11, 2022, 3:40 p.m. UTC
It is unneeded, as this decoder does not call ff_get_buffer().

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/wrapped_avframe.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Andreas Rheinhardt May 13, 2022, 5:07 p.m. UTC | #1
Andreas Rheinhardt:
> It is unneeded, as this decoder does not call ff_get_buffer().
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/wrapped_avframe.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/libavcodec/wrapped_avframe.c b/libavcodec/wrapped_avframe.c
> index 3af007d478..06c274eed0 100644
> --- a/libavcodec/wrapped_avframe.c
> +++ b/libavcodec/wrapped_avframe.c
> @@ -98,12 +98,6 @@ static int wrapped_avframe_decode(AVCodecContext *avctx, AVFrame *out,
>  
>      av_frame_move_ref(out, in);
>  
> -    err = ff_attach_decode_data(out);
> -    if (err < 0) {
> -        av_frame_unref(out);
> -        return err;
> -    }
> -
>      *got_frame = 1;
>      return 0;
>  }

Will apply this patch tomorrow.
And I'd really hope that someone can review and/or test patch 2/2.

- Andreas
diff mbox series

Patch

diff --git a/libavcodec/wrapped_avframe.c b/libavcodec/wrapped_avframe.c
index 3af007d478..06c274eed0 100644
--- a/libavcodec/wrapped_avframe.c
+++ b/libavcodec/wrapped_avframe.c
@@ -98,12 +98,6 @@  static int wrapped_avframe_decode(AVCodecContext *avctx, AVFrame *out,
 
     av_frame_move_ref(out, in);
 
-    err = ff_attach_decode_data(out);
-    if (err < 0) {
-        av_frame_unref(out);
-        return err;
-    }
-
     *got_frame = 1;
     return 0;
 }