diff mbox series

[FFmpeg-devel,01/11] avcodec/tests/avcodec: Mark frame-thrd encoder incompatible with delay

Message ID DB6PR0101MB22147759BB89DB6819E1B5998F739@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com
State Accepted
Commit e405298ebded794a4ad84222c56b6c0245530afc
Headers show
Series [FFmpeg-devel,01/11] avcodec/tests/avcodec: Mark frame-thrd encoder incompatible with delay | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Aug. 24, 2022, 1:28 a.m. UTC 
The API for frame-threaded encoders only works
for one-in-one-out encoders.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/tests/avcodec.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Andreas Rheinhardt Aug. 26, 2022, 12:31 a.m. UTC | #1 
Andreas Rheinhardt:
> The API for frame-threaded encoders only works
> for one-in-one-out encoders.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/tests/avcodec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/tests/avcodec.c b/libavcodec/tests/avcodec.c
> index 08b5fbede1..3288a85f64 100644
> --- a/libavcodec/tests/avcodec.c
> +++ b/libavcodec/tests/avcodec.c
> @@ -155,6 +155,9 @@ int main(void){
>              if (codec->capabilities & AV_CODEC_CAP_FRAME_THREADS &&
>                  codec->capabilities & AV_CODEC_CAP_ENCODER_FLUSH)
>                  ERR("Frame-threaded encoder %s claims to support flushing\n");
> +            if (codec->capabilities & AV_CODEC_CAP_FRAME_THREADS &&
> +                codec->capabilities & AV_CODEC_CAP_DELAY)
> +                ERR("Frame-threaded encoder %s claims to have delay\n");
>          } else {
>              if ((codec->type == AVMEDIA_TYPE_SUBTITLE) != (codec2->cb_type == FF_CODEC_CB_TYPE_DECODE_SUB))
>                  ERR("Subtitle decoder %s does not implement decode_sub callback\n");

Will apply the first eleven patches of this patchset (with v2 of #11)
tonight unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/libavcodec/tests/avcodec.c b/libavcodec/tests/avcodec.c
index 08b5fbede1..3288a85f64 100644
--- a/libavcodec/tests/avcodec.c
+++ b/libavcodec/tests/avcodec.c
@@ -155,6 +155,9 @@  int main(void){
             if (codec->capabilities & AV_CODEC_CAP_FRAME_THREADS &&
                 codec->capabilities & AV_CODEC_CAP_ENCODER_FLUSH)
                 ERR("Frame-threaded encoder %s claims to support flushing\n");
+            if (codec->capabilities & AV_CODEC_CAP_FRAME_THREADS &&
+                codec->capabilities & AV_CODEC_CAP_DELAY)
+                ERR("Frame-threaded encoder %s claims to have delay\n");
         } else {
             if ((codec->type == AVMEDIA_TYPE_SUBTITLE) != (codec2->cb_type == FF_CODEC_CB_TYPE_DECODE_SUB))
                 ERR("Subtitle decoder %s does not implement decode_sub callback\n");