diff mbox series

[FFmpeg-devel] avformat/matroskaenc: Fix use of uninitialized value

Message ID DB6PR0101MB2214CF1D06802245220AC5B38FB69@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com
State Accepted
Commit 2cce1d852862c91a14a9921bf15a7e0e027c7164
Headers show
Series [FFmpeg-devel] avformat/matroskaenc: Fix use of uninitialized value | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_armv7_RPi4 success Make finished
andriy/make_fate_armv7_RPi4 success Make fate finished

Commit Message

Andreas Rheinhardt June 26, 2022, 4:20 a.m. UTC 
Regression since 67eea6cf026a70940ea402d54685d67c660b49cd.
Affects only WebVTT when muxing WebM. (This is covered
by the webm-webvtt-remux FATE test which fails for several
FATE boxes on fate-ffmpeg.org.)

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
I tested with Valgrind before 67eea6cf026a70940ea402d54685d67c660b49cd
and it didn't fail. It only fails on -O0; Disabling stack reuse
is not enough to make it fail.
Anyway, will apply this soon.

 libavformat/matroskaenc.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 4f5afc1be4..1256bdfe36 100644
--- a/libavformat/matroskaenc.c
+++ b/libavformat/matroskaenc.c
@@ -1914,6 +1914,7 @@  static int mkv_write_track(AVFormatContext *s, MatroskaMuxContext *mkv,
     }
 
     end_ebml_master(pb, track_master);
+    ret = 0;
 fail:
     ffio_reset_dyn_buf(mkv->tmp_bc);