| Message ID | DB6PR0101MB2214CFCDC76D49C74AA391768FD19@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com |
|---|---|
| State | Accepted |
| Commit | c37f65a588a1892e448d386c0821aaa31297a763 |
| Headers | show |
| Series | [FFmpeg-devel,1/6] tests/Makefile: Remove FILTERDEMDECMUX | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
Andreas Rheinhardt: > It is unused and given that one needs an encoder to produce > packets from AVFrames (as output by filters) this is likely > to remain so, because FILTERDEMDECENCMUX is better for these > scenarios. > The only case where one can use filters without encoders is > with the lavfi input device: It outputs AVPackets which could > be copied without another conversion to AVFrames. Yet the variable > to check for this is CONFIG_LAVFI_INDEV, but FILTERDEMDECMUX > is designed to work with demuxers (i.e. CONFIG_*_DEMUXER). > So there is no usecase for FILTERDEMDECMUX. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > --- > tests/Makefile | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/Makefile b/tests/Makefile > index 7ddfbcfd7e..5cb33b6c65 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -111,7 +111,6 @@ FRAMECRC = $(call ALLYES, $(1)_DEMUXER $(2:%=%_DECODER) $(3) \ > DEMMUX = $(call ALLYES, $(1)_DEMUXER $(2)_MUXER $(3) FILE_PROTOCOL) > > FILTERDEMDEC = $(call ALLYES, $(1:%=%_FILTER) $(2)_DEMUXER $(3)_DECODER $(4) FILE_PROTOCOL) > -FILTERDEMDECMUX = $(call ALLYES, $(1:%=%_FILTER) $(2)_DEMUXER $(3)_DECODER $(4)_MUXER $(5) FILE_PROTOCOL) > FILTERDEMDECENCMUX = $(call ALLYES, $(1:%=%_FILTER) $(2)_DEMUXER $(3)_DECODER $(4)_ENCODER $(5)_MUXER $(6) FILE_PROTOCOL) > > PARSERDEMDEC = $(call ALLYES, $(1)_PARSER $(2)_DEMUXER $(3)_DECODER $(4) FILE_PROTOCOL) Will apply this patchset tomorrow unless there are objections. - Andreas
diff --git a/tests/Makefile b/tests/Makefile index 7ddfbcfd7e..5cb33b6c65 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -111,7 +111,6 @@ FRAMECRC = $(call ALLYES, $(1)_DEMUXER $(2:%=%_DECODER) $(3) \ DEMMUX = $(call ALLYES, $(1)_DEMUXER $(2)_MUXER $(3) FILE_PROTOCOL) FILTERDEMDEC = $(call ALLYES, $(1:%=%_FILTER) $(2)_DEMUXER $(3)_DECODER $(4) FILE_PROTOCOL) -FILTERDEMDECMUX = $(call ALLYES, $(1:%=%_FILTER) $(2)_DEMUXER $(3)_DECODER $(4)_MUXER $(5) FILE_PROTOCOL) FILTERDEMDECENCMUX = $(call ALLYES, $(1:%=%_FILTER) $(2)_DEMUXER $(3)_DECODER $(4)_ENCODER $(5)_MUXER $(6) FILE_PROTOCOL) PARSERDEMDEC = $(call ALLYES, $(1)_PARSER $(2)_DEMUXER $(3)_DECODER $(4) FILE_PROTOCOL)
It is unused and given that one needs an encoder to produce packets from AVFrames (as output by filters) this is likely to remain so, because FILTERDEMDECENCMUX is better for these scenarios. The only case where one can use filters without encoders is with the lavfi input device: It outputs AVPackets which could be copied without another conversion to AVFrames. Yet the variable to check for this is CONFIG_LAVFI_INDEV, but FILTERDEMDECMUX is designed to work with demuxers (i.e. CONFIG_*_DEMUXER). So there is no usecase for FILTERDEMDECMUX. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- tests/Makefile | 1 - 1 file changed, 1 deletion(-)