diff mbox series

[FFmpeg-devel,01/20] avcodec/hevc_sei: Use proper type for NALU type

Message ID DB6PR0101MB2214F50F230E6F64A2428AED8FBC9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com
State Accepted
Commit aba0cc44656be6ee283349713ac888501ca597ba
Headers show
Series [FFmpeg-devel,01/20] avcodec/hevc_sei: Use proper type for NALU type | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt July 2, 2022, 10:20 p.m. UTC
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/hevc_sei.c | 2 +-
 libavcodec/hevc_sei.h | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Soft Works July 2, 2022, 11:28 p.m. UTC | #1
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: Sunday, July 3, 2022 12:21 AM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> Subject: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper
> type for NALU type
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---

Nice! That's helpful for the QSV SEI parsing. The one missing bit 
is the HDR data (AVMasteringDisplayMetadata and AVContentLightMetadata)
assignment which still seems to remain in hevcdec. Would it make sense
for factor this out as well?

Thank you very much,
softworkz
diff mbox series

Patch

diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c
index 953633f4bd..631373e06f 100644
--- a/libavcodec/hevc_sei.c
+++ b/libavcodec/hevc_sei.c
@@ -550,7 +550,7 @@  static int decode_nal_sei_message(GetByteContext *gb, void *logctx, HEVCSEI *s,
 }
 
 int ff_hevc_decode_nal_sei(GetBitContext *gb, void *logctx, HEVCSEI *s,
-                           const HEVCParamSets *ps, int type)
+                           const HEVCParamSets *ps, enum HEVCNALUnitType type)
 {
     GetByteContext gbyte;
     int ret;
diff --git a/libavcodec/hevc_sei.h b/libavcodec/hevc_sei.h
index f198402333..ef987f6781 100644
--- a/libavcodec/hevc_sei.h
+++ b/libavcodec/hevc_sei.h
@@ -26,6 +26,7 @@ 
 #include "libavutil/buffer.h"
 
 #include "get_bits.h"
+#include "hevc.h"
 #include "sei.h"
 
 
@@ -154,7 +155,7 @@  typedef struct HEVCSEI {
 struct HEVCParamSets;
 
 int ff_hevc_decode_nal_sei(GetBitContext *gb, void *logctx, HEVCSEI *s,
-                           const struct HEVCParamSets *ps, int type);
+                           const struct HEVCParamSets *ps, enum HEVCNALUnitType type);
 
 /**
  * Reset SEI values that are stored on the Context.