diff mbox series

[FFmpeg-devel,3/3] avcodec/cbs_h266_syntax_template: Avoid shadowing

Message ID GV1P250MB07373A7DC146DE13A0B6F5BC8F2AA@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit e7f152a8c2214f5d82dccdc49734f050469f5869
Headers show
Series [FFmpeg-devel,1/2] avcodec/cbs_h266_syntax_template: Don't use uninitialized value | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt June 30, 2023, 10:07 p.m. UTC 
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/cbs_h266_syntax_template.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Nuo Mi July 1, 2023, 2:37 p.m. UTC | #1 
On Sat, Jul 1, 2023 at 6:07 AM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/cbs_h266_syntax_template.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/cbs_h266_syntax_template.c
> b/libavcodec/cbs_h266_syntax_template.c
> index a329b7f9ed..646cd94413 100644
> --- a/libavcodec/cbs_h266_syntax_template.c
> +++ b/libavcodec/cbs_h266_syntax_template.c
> @@ -514,9 +514,9 @@ static int FUNC(ref_pic_lists) (CodedBitstreamContext
> *ctx, RWContext *rw,
>          ref_list = &current->rpl_ref_list[i];
>
>          num_ltrp_entries = 0;
> -        for (int i = 0; i < ref_list->num_ref_entries; i++) {
> -            if (!ref_list->inter_layer_ref_pic_flag[i]) {
> -                if (!ref_list->st_ref_pic_flag[i]) {
> +        for (int k = 0; k < ref_list->num_ref_entries; k++) {
> +            if (!ref_list->inter_layer_ref_pic_flag[k]) {
> +                if (!ref_list->st_ref_pic_flag[k]) {
>                      num_ltrp_entries++;
>                  }
>              }
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
:) LGTM
diff mbox series

Patch

diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c
index a329b7f9ed..646cd94413 100644
--- a/libavcodec/cbs_h266_syntax_template.c
+++ b/libavcodec/cbs_h266_syntax_template.c
@@ -514,9 +514,9 @@  static int FUNC(ref_pic_lists) (CodedBitstreamContext *ctx, RWContext *rw,
         ref_list = &current->rpl_ref_list[i];
 
         num_ltrp_entries = 0;
-        for (int i = 0; i < ref_list->num_ref_entries; i++) {
-            if (!ref_list->inter_layer_ref_pic_flag[i]) {
-                if (!ref_list->st_ref_pic_flag[i]) {
+        for (int k = 0; k < ref_list->num_ref_entries; k++) {
+            if (!ref_list->inter_layer_ref_pic_flag[k]) {
+                if (!ref_list->st_ref_pic_flag[k]) {
                     num_ltrp_entries++;
                 }
             }