diff mbox series

[FFmpeg-devel] fftools/ffmpeg_enc: Don't call frame_data twice

Message ID GV1P250MB07374FCA6F0F55D55CA5F9218F312@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit c77164390b6432626d970d197c2da44f408071bc
Headers show
Series [FFmpeg-devel] fftools/ffmpeg_enc: Don't call frame_data twice | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt March 22, 2024, 4:07 p.m. UTC 
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 fftools/ffmpeg_enc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jan Ekström March 22, 2024, 4:46 p.m. UTC | #1 
On Fri, Mar 22, 2024 at 6:07 PM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  fftools/ffmpeg_enc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c
> index f01be1c22f..5f7fcf8a5f 100644
> --- a/fftools/ffmpeg_enc.c
> +++ b/fftools/ffmpeg_enc.c
> @@ -646,7 +646,6 @@ static int encode_frame(OutputFile *of, OutputStream *ost, AVFrame *frame,
>      if (frame) {
>          FrameData *fd = frame_data(frame);
>
> -        fd = frame_data(frame);
>          if (!fd)
>              return AVERROR(ENOMEM);
>

Good catch, LGTM.

Jan
diff mbox series

Patch

diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c
index f01be1c22f..5f7fcf8a5f 100644
--- a/fftools/ffmpeg_enc.c
+++ b/fftools/ffmpeg_enc.c
@@ -646,7 +646,6 @@  static int encode_frame(OutputFile *of, OutputStream *ost, AVFrame *frame,
     if (frame) {
         FrameData *fd = frame_data(frame);
 
-        fd = frame_data(frame);
         if (!fd)
             return AVERROR(ENOMEM);