diff mbox series

[FFmpeg-devel,01/15] configure: Make hls demuxer select AAC, AC3 and EAC3 demuxers

Message ID GV1P250MB07376CBB2E248FDF0C78CF8C8F302@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit 8d8b5947c336eeee9a46e62969dfefd7e112d256
Headers show
Series [FFmpeg-devel,01/15] configure: Make hls demuxer select AAC, AC3 and EAC3 demuxers | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt March 23, 2024, 2:03 a.m. UTC 
The code relies on their presence and would presumably crash
when retrieving in_fmt->name if an encrypted stream with a codec id
without demuxer were encountered.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Rheinhardt March 25, 2024, 1:54 a.m. UTC | #1 
Andreas Rheinhardt:
> The code relies on their presence and would presumably crash
> when retrieving in_fmt->name if an encrypted stream with a codec id
> without demuxer were encountered.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 343edb38ab..90d18e0970 100755
> --- a/configure
> +++ b/configure
> @@ -3590,7 +3590,7 @@ flac_demuxer_select="flac_parser"
>  flv_muxer_select="aac_adtstoasc_bsf"
>  gxf_muxer_select="pcm_rechunk_bsf"
>  hds_muxer_select="flv_muxer"
> -hls_demuxer_select="adts_header ac3_parser mov_demuxer mpegts_demuxer"
> +hls_demuxer_select="aac_demuxer ac3_demuxer adts_header ac3_parser eac3_demuxer mov_demuxer mpegts_demuxer"
>  hls_muxer_select="mov_muxer mpegts_muxer"
>  iamf_demuxer_select="iamfdec"
>  iamf_muxer_select="iamfenc"

Will apply this patchset tomorrow unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/configure b/configure
index 343edb38ab..90d18e0970 100755
--- a/configure
+++ b/configure
@@ -3590,7 +3590,7 @@  flac_demuxer_select="flac_parser"
 flv_muxer_select="aac_adtstoasc_bsf"
 gxf_muxer_select="pcm_rechunk_bsf"
 hds_muxer_select="flv_muxer"
-hls_demuxer_select="adts_header ac3_parser mov_demuxer mpegts_demuxer"
+hls_demuxer_select="aac_demuxer ac3_demuxer adts_header ac3_parser eac3_demuxer mov_demuxer mpegts_demuxer"
 hls_muxer_select="mov_muxer mpegts_muxer"
 iamf_demuxer_select="iamfdec"
 iamf_muxer_select="iamfenc"