diff mbox series

[FFmpeg-devel,1/4] swscale/x86/rgb2rgb_template: Remove unnecessary SFENCE

Message ID GV1P250MB073797DF5AC7A41CD8735E158FF92@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
State New
Headers show
Series [FFmpeg-devel,1/4] swscale/x86/rgb2rgb_template: Remove unnecessary SFENCE | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt June 5, 2024, 9:37 p.m. UTC
The ff_nv12ToUV_* functions don't use non-temporal stores
at all.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libswscale/x86/rgb2rgb_template.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Andreas Rheinhardt June 8, 2024, 7:44 p.m. UTC | #1
Andreas Rheinhardt:
> The ff_nv12ToUV_* functions don't use non-temporal stores
> at all.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libswscale/x86/rgb2rgb_template.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/libswscale/x86/rgb2rgb_template.c b/libswscale/x86/rgb2rgb_template.c
> index edbacea784..e4e884827c 100644
> --- a/libswscale/x86/rgb2rgb_template.c
> +++ b/libswscale/x86/rgb2rgb_template.c
> @@ -1837,10 +1837,6 @@ static void RENAME(deinterleaveBytes)(const uint8_t *src, uint8_t *dst1, uint8_t
>          dst1 += dst1Stride;
>          dst2 += dst2Stride;
>      }
> -    __asm__(
> -            SFENCE"     \n\t"
> -            ::: "memory"
> -            );
>  }
>  #endif /* COMPILE_TEMPLATE_SSE2 && HAVE_X86ASM */
>  #endif /* !COMPILE_TEMPLATE_AVX || HAVE_AVX_EXTERNAL */

Will apply this patchset tomorrow unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/libswscale/x86/rgb2rgb_template.c b/libswscale/x86/rgb2rgb_template.c
index edbacea784..e4e884827c 100644
--- a/libswscale/x86/rgb2rgb_template.c
+++ b/libswscale/x86/rgb2rgb_template.c
@@ -1837,10 +1837,6 @@  static void RENAME(deinterleaveBytes)(const uint8_t *src, uint8_t *dst1, uint8_t
         dst1 += dst1Stride;
         dst2 += dst2Stride;
     }
-    __asm__(
-            SFENCE"     \n\t"
-            ::: "memory"
-            );
 }
 #endif /* COMPILE_TEMPLATE_SSE2 && HAVE_X86ASM */
 #endif /* !COMPILE_TEMPLATE_AVX || HAVE_AVX_EXTERNAL */