| Message ID | GV1P250MB0737BDE0C352786E0D16EFD38FEB2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM |
|---|---|
| State | Accepted |
| Commit | e9197db4f7227a341b781c227a0a8f3a99033b5e |
| Headers | show |
| Series | [FFmpeg-devel] tests/checkasm/vvc_alf: Don't use declare_func_emms | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Wed, 22 May 2024, Andreas Rheinhardt wrote: > VVC does not have MMX code at all, so one can use the stricter > declare_func to also check that the MMX state has not been clobbered > with (which would be an ABI violation). > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > --- > tests/checkasm/vvc_alf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c > index 6dd89bfafc..f35fd2cd3e 100644 > --- a/tests/checkasm/vvc_alf.c > +++ b/tests/checkasm/vvc_alf.c > @@ -83,7 +83,7 @@ static void check_alf_filter(VVCDSPContext *c, const int bit_depth) > ptrdiff_t dst_stride = DST_PIXEL_STRIDE * SIZEOF_PIXEL; > int offset = (3 * SRC_PIXEL_STRIDE + 3) * SIZEOF_PIXEL; > > - declare_func_emms(AV_CPU_FLAG_AVX2, void, uint8_t *dst, ptrdiff_t dst_stride, const uint8_t *src, ptrdiff_t src_stride, > + declare_func(void, uint8_t *dst, ptrdiff_t dst_stride, const uint8_t *src, ptrdiff_t src_stride, > int width, int height, const int16_t *filter, const int16_t *clip, const int vb_pos); > > randomize_buffers(src0, src1, SRC_BUF_SIZE); > @@ -137,7 +137,7 @@ static void check_alf_classify(VVCDSPContext *c, const int bit_depth) > ptrdiff_t stride = SRC_PIXEL_STRIDE * SIZEOF_PIXEL; > int offset = (3 * SRC_PIXEL_STRIDE + 3) * SIZEOF_PIXEL; > > - declare_func_emms(AV_CPU_FLAG_AVX2, void, int *class_idx, int *transpose_idx, > + declare_func(void, int *class_idx, int *transpose_idx, > const uint8_t *src, ptrdiff_t src_stride, int width, int height, int vb_pos, int *gradient_tmp); > > randomize_buffers(src0, src1, SRC_BUF_SIZE); > -- > 2.40.1 LGTM // Martin
Andreas Rheinhardt: > VVC does not have MMX code at all, so one can use the stricter > declare_func to also check that the MMX state has not been clobbered > with (which would be an ABI violation). > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > --- > tests/checkasm/vvc_alf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c > index 6dd89bfafc..f35fd2cd3e 100644 > --- a/tests/checkasm/vvc_alf.c > +++ b/tests/checkasm/vvc_alf.c > @@ -83,7 +83,7 @@ static void check_alf_filter(VVCDSPContext *c, const int bit_depth) > ptrdiff_t dst_stride = DST_PIXEL_STRIDE * SIZEOF_PIXEL; > int offset = (3 * SRC_PIXEL_STRIDE + 3) * SIZEOF_PIXEL; > > - declare_func_emms(AV_CPU_FLAG_AVX2, void, uint8_t *dst, ptrdiff_t dst_stride, const uint8_t *src, ptrdiff_t src_stride, > + declare_func(void, uint8_t *dst, ptrdiff_t dst_stride, const uint8_t *src, ptrdiff_t src_stride, > int width, int height, const int16_t *filter, const int16_t *clip, const int vb_pos); > > randomize_buffers(src0, src1, SRC_BUF_SIZE); > @@ -137,7 +137,7 @@ static void check_alf_classify(VVCDSPContext *c, const int bit_depth) > ptrdiff_t stride = SRC_PIXEL_STRIDE * SIZEOF_PIXEL; > int offset = (3 * SRC_PIXEL_STRIDE + 3) * SIZEOF_PIXEL; > > - declare_func_emms(AV_CPU_FLAG_AVX2, void, int *class_idx, int *transpose_idx, > + declare_func(void, int *class_idx, int *transpose_idx, > const uint8_t *src, ptrdiff_t src_stride, int width, int height, int vb_pos, int *gradient_tmp); > > randomize_buffers(src0, src1, SRC_BUF_SIZE); Will apply this patch tomorrow unless there are objections. - Andreas
diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c index 6dd89bfafc..f35fd2cd3e 100644 --- a/tests/checkasm/vvc_alf.c +++ b/tests/checkasm/vvc_alf.c @@ -83,7 +83,7 @@ static void check_alf_filter(VVCDSPContext *c, const int bit_depth) ptrdiff_t dst_stride = DST_PIXEL_STRIDE * SIZEOF_PIXEL; int offset = (3 * SRC_PIXEL_STRIDE + 3) * SIZEOF_PIXEL; - declare_func_emms(AV_CPU_FLAG_AVX2, void, uint8_t *dst, ptrdiff_t dst_stride, const uint8_t *src, ptrdiff_t src_stride, + declare_func(void, uint8_t *dst, ptrdiff_t dst_stride, const uint8_t *src, ptrdiff_t src_stride, int width, int height, const int16_t *filter, const int16_t *clip, const int vb_pos); randomize_buffers(src0, src1, SRC_BUF_SIZE); @@ -137,7 +137,7 @@ static void check_alf_classify(VVCDSPContext *c, const int bit_depth) ptrdiff_t stride = SRC_PIXEL_STRIDE * SIZEOF_PIXEL; int offset = (3 * SRC_PIXEL_STRIDE + 3) * SIZEOF_PIXEL; - declare_func_emms(AV_CPU_FLAG_AVX2, void, int *class_idx, int *transpose_idx, + declare_func(void, int *class_idx, int *transpose_idx, const uint8_t *src, ptrdiff_t src_stride, int width, int height, int vb_pos, int *gradient_tmp); randomize_buffers(src0, src1, SRC_BUF_SIZE);
VVC does not have MMX code at all, so one can use the stricter declare_func to also check that the MMX state has not been clobbered with (which would be an ABI violation). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- tests/checkasm/vvc_alf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)