diff mbox series

[FFmpeg-devel] fftools/ffmpeg_mux_init: Fix leak when using non-encoding option

Message ID GV1P250MB0737BF34DE44BE3DD30D53EE8FC72@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
State New
Headers show
Series [FFmpeg-devel] fftools/ffmpeg_mux_init: Fix leak when using non-encoding option | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt June 11, 2024, 6:37 a.m. UTC 
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 fftools/ffmpeg_mux_init.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Anton Khirnov June 11, 2024, 11:23 a.m. UTC | #1 
Quoting Andreas Rheinhardt (2024-06-11 08:37:59)
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  fftools/ffmpeg_mux_init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
> index 2ed4171a75..e25c6e7e24 100644
> --- a/fftools/ffmpeg_mux_init.c
> +++ b/fftools/ffmpeg_mux_init.c
> @@ -3146,6 +3146,7 @@ static int validate_enc_avopt(Muxer *mux, const AVDictionary *codec_avopt)
>          if (!(option->flags & AV_OPT_FLAG_ENCODING_PARAM)) {
>              av_log(mux, AV_LOG_ERROR, "Codec AVOption %s (%s) is not an "
>                     "encoding option.\n", e->key, option->help ? option->help : "");
> +            av_dict_free(&unused_opts);
>              return AVERROR(EINVAL);

LGTM
diff mbox series

Patch

diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
index 2ed4171a75..e25c6e7e24 100644
--- a/fftools/ffmpeg_mux_init.c
+++ b/fftools/ffmpeg_mux_init.c
@@ -3146,6 +3146,7 @@  static int validate_enc_avopt(Muxer *mux, const AVDictionary *codec_avopt)
         if (!(option->flags & AV_OPT_FLAG_ENCODING_PARAM)) {
             av_log(mux, AV_LOG_ERROR, "Codec AVOption %s (%s) is not an "
                    "encoding option.\n", e->key, option->help ? option->help : "");
+            av_dict_free(&unused_opts);
             return AVERROR(EINVAL);
         }