diff mbox series

[FFmpeg-devel,1/9] checkasm/vc1dsp: Use declare_func_emms only when needed

Message ID GV1P250MB0737C14BE0518E155E6AC4D88F5E9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit f224c195e00ec0235e4f85207208deca5ed7eb47
Headers show
Series [FFmpeg-devel,1/9] checkasm/vc1dsp: Use declare_func_emms only when needed | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Oct. 8, 2022, 1:23 a.m. UTC 
There is no MMX code for vc1_inv_trans_8x8 or
vc1_unescape_buffer, so use declare_func instead of
declare_func_emms() to also test that we are not in MMX
mode after return.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 tests/checkasm/vc1dsp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andreas Rheinhardt Oct. 10, 2022, 12:30 a.m. UTC | #1 
Andreas Rheinhardt:
> There is no MMX code for vc1_inv_trans_8x8 or
> vc1_unescape_buffer, so use declare_func instead of
> declare_func_emms() to also test that we are not in MMX
> mode after return.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  tests/checkasm/vc1dsp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/checkasm/vc1dsp.c b/tests/checkasm/vc1dsp.c
> index 52628d15e4..570785776f 100644
> --- a/tests/checkasm/vc1dsp.c
> +++ b/tests/checkasm/vc1dsp.c
> @@ -261,7 +261,7 @@ static void check_inv_trans_inplace(void)
>  
>      if (check_func(h.vc1_inv_trans_8x8, "vc1dsp.vc1_inv_trans_8x8")) {
>          matrix *coeffs;
> -        declare_func_emms(AV_CPU_FLAG_MMX, void, int16_t *);
> +        declare_func(void, int16_t *);
>          RANDOMIZE_BUFFER16(inv_trans_in, 10 * 8);
>          coeffs = generate_inverse_quantized_transform_coefficients(8, 8);
>          for (int j = 0; j < 8; ++j)
> @@ -404,7 +404,7 @@ static void check_unescape(void)
>  
>      if (check_func(h.vc1_unescape_buffer, "vc1dsp.vc1_unescape_buffer")) {
>          int len0, len1, escaped_offset, unescaped_offset, escaped_len;
> -        declare_func_emms(AV_CPU_FLAG_MMX, int, const uint8_t *, int, uint8_t *);
> +        declare_func(int, const uint8_t *, int, uint8_t *);
>  
>          /* Test data which consists of escapes sequences packed as tightly as possible */
>          for (int x = 0; x < UNESCAPE_BUF_SIZE; ++x)

Will apply this patchset tomorrow unless there are objections.

- Andreas
diff mbox series

Patch

diff --git a/tests/checkasm/vc1dsp.c b/tests/checkasm/vc1dsp.c
index 52628d15e4..570785776f 100644
--- a/tests/checkasm/vc1dsp.c
+++ b/tests/checkasm/vc1dsp.c
@@ -261,7 +261,7 @@  static void check_inv_trans_inplace(void)
 
     if (check_func(h.vc1_inv_trans_8x8, "vc1dsp.vc1_inv_trans_8x8")) {
         matrix *coeffs;
-        declare_func_emms(AV_CPU_FLAG_MMX, void, int16_t *);
+        declare_func(void, int16_t *);
         RANDOMIZE_BUFFER16(inv_trans_in, 10 * 8);
         coeffs = generate_inverse_quantized_transform_coefficients(8, 8);
         for (int j = 0; j < 8; ++j)
@@ -404,7 +404,7 @@  static void check_unescape(void)
 
     if (check_func(h.vc1_unescape_buffer, "vc1dsp.vc1_unescape_buffer")) {
         int len0, len1, escaped_offset, unescaped_offset, escaped_len;
-        declare_func_emms(AV_CPU_FLAG_MMX, int, const uint8_t *, int, uint8_t *);
+        declare_func(int, const uint8_t *, int, uint8_t *);
 
         /* Test data which consists of escapes sequences packed as tightly as possible */
         for (int x = 0; x < UNESCAPE_BUF_SIZE; ++x)