diff mbox series

[FFmpeg-devel,RFC,2/2] tests/fate/source-check: Relax BSD licence check

Message ID GV1P250MB0737CB6F11B87A647FBD0BE58FEB2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit 41e13228451c9d55b1ebf2f58ffe2b19ce5a9842
Headers show
Series [FFmpeg-devel,1/2] doc/mips: Update list of files with MIPS copyright notice | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished

Commit Message

Andreas Rheinhardt May 22, 2024, 11:04 a.m. UTC
Several files already had standard license header (namely
2-clause BSD files), yet due to the 80 char line length limit,
they were not treated as such by source-check.sh (which
fate-source uses). Therefore relax the BSD check.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
This is the first variant. The second variant follows shortly.

 tests/fate/source-check.sh | 2 +-
 tests/ref/fate/source      | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)

Comments

Rémi Denis-Courmont May 22, 2024, 12:40 p.m. UTC | #1
Le 22 mai 2024 14:04:50 GMT+03:00, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> a écrit :
>Several files already had standard license header (namely
>2-clause BSD files), yet due to the 80 char line length limit,
>they were not treated as such by source-check.sh (which
>fate-source uses). Therefore relax the BSD check.

LGTM.
Pierre-Anthony Lemieux May 25, 2024, 8:43 p.m. UTC | #2
On Wed, May 22, 2024 at 4:38 AM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Several files already had standard license header (namely
> 2-clause BSD files), yet due to the 80 char line length limit,
> they were not treated as such by source-check.sh (which
> fate-source uses). Therefore relax the BSD check.

LGTM

>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> This is the first variant. The second variant follows shortly.
>
>  tests/fate/source-check.sh | 2 +-
>  tests/ref/fate/source      | 5 -----
>  2 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/tests/fate/source-check.sh b/tests/fate/source-check.sh
> index 658823fc0b..4d7e175784 100755
> --- a/tests/fate/source-check.sh
> +++ b/tests/fate/source-check.sh
> @@ -11,7 +11,7 @@ git grep -L -E "This file is part of FFmpeg|This file is part of libswresample|"
>  "Permission is hereby granted to use, copy, modify, and distribute this|"\
>  "Permission is granted to anyone to use this software for any purpose|"\
>  "This work is licensed under the terms of the GNU GPL|"\
> -"Redistribution and use in source and binary forms, with or without modification|"\
> +"Redistribution and use in source and binary forms, with or without|"\
>  "This library is free software; you can redistribute it and/or|"\
>  "This program is free software; you can redistribute it and/or modify|"\
>  "Licensed under the Apache License|"\
> diff --git a/tests/ref/fate/source b/tests/ref/fate/source
> index 723e2e06c7..a3beb35093 100644
> --- a/tests/ref/fate/source
> +++ b/tests/ref/fate/source
> @@ -1,15 +1,10 @@
>  Files without standard license headers:
>  libavcodec/file_open.c
> -libavcodec/ilbcdata.h
> -libavcodec/ilbcdec.c
>  libavcodec/interplayacm.c
>  libavcodec/log2_tab.c
>  libavcodec/reverse.c
> -libavcodec/riscv/startcode_rvb.S
> -libavcodec/riscv/startcode_rvv.S
>  libavdevice/file_open.c
>  libavdevice/reverse.c
> -libavfilter/af_arnndn.c
>  libavfilter/file_open.c
>  libavfilter/log2_tab.c
>  libavformat/bitstream.c
> --
> 2.40.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/tests/fate/source-check.sh b/tests/fate/source-check.sh
index 658823fc0b..4d7e175784 100755
--- a/tests/fate/source-check.sh
+++ b/tests/fate/source-check.sh
@@ -11,7 +11,7 @@  git grep -L -E "This file is part of FFmpeg|This file is part of libswresample|"
 "Permission is hereby granted to use, copy, modify, and distribute this|"\
 "Permission is granted to anyone to use this software for any purpose|"\
 "This work is licensed under the terms of the GNU GPL|"\
-"Redistribution and use in source and binary forms, with or without modification|"\
+"Redistribution and use in source and binary forms, with or without|"\
 "This library is free software; you can redistribute it and/or|"\
 "This program is free software; you can redistribute it and/or modify|"\
 "Licensed under the Apache License|"\
diff --git a/tests/ref/fate/source b/tests/ref/fate/source
index 723e2e06c7..a3beb35093 100644
--- a/tests/ref/fate/source
+++ b/tests/ref/fate/source
@@ -1,15 +1,10 @@ 
 Files without standard license headers:
 libavcodec/file_open.c
-libavcodec/ilbcdata.h
-libavcodec/ilbcdec.c
 libavcodec/interplayacm.c
 libavcodec/log2_tab.c
 libavcodec/reverse.c
-libavcodec/riscv/startcode_rvb.S
-libavcodec/riscv/startcode_rvv.S
 libavdevice/file_open.c
 libavdevice/reverse.c
-libavfilter/af_arnndn.c
 libavfilter/file_open.c
 libavfilter/log2_tab.c
 libavformat/bitstream.c